Skip to contentSkip to conversation

hwmon: (lm95245) Drop useless debug message

PATCH In review Guenter Roeck 2 participants 2 messages Feb 22, 2014 – Feb 23, 2014 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH v2 3/4 hwmon: (lm95245) Drop useless debug message

It doesn't provide value to get a log message whenever the driver updates its cached data, so drop the message.

---
v2: Additional patch

 drivers/hwmon/lm95245.c |    1 -
 1 file changed, 1 deletion(-)
drivers/hwmon/lm95245.c +0 -1
index b62a1f4..310e145 100644
@@ -149,7 +149,6 @@ static struct lm95245_data *lm95245_update_device(struct device *dev)
 		+ msecs_to_jiffies(data->interval)) || !data->valid) {
 		int i;
 
-		dev_dbg(dev, "Updating lm95245 data.\n");
 		for (i = 0; i < ARRAY_SIZE(lm95245_reg_address); i++)
 			data->regs[i]
 			  = i2c_smbus_read_byte_data(client,
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Reviewed-by on v2 3/4
#1 lore raw
Quoted 15 lines · Guenter Roeck

It doesn't provide value to get a log message whenever the driver updates its cached data, so drop the message.

---
v2: Additional patch

 drivers/hwmon/lm95245.c |    1 -
 1 file changed, 1 deletion(-)
drivers/hwmon/lm95245.c +0 -0
index b62a1f4..310e145 100644

drivers/hwmon/lm95245.c static struct lm95245_data *lm95245_update_device(struct device *dev) · line 154

Quoted 7 lines
drivers/hwmon/lm95245.c +0 -1
@@ -149,7 +149,6 @@ static struct lm95245_data *lm95245_update_device(struct device *dev)
 		+ msecs_to_jiffies(data->interval)) || !data->valid) {
 		int i;
 
-		dev_dbg(dev, "Updating lm95245 data.\n");
 		for (i = 0; i < ARRAY_SIZE(lm95245_reg_address); i++)
 			data->regs[i]
 			  = i2c_smbus_read_byte_data(client,
Signature · 7 lines
Jean Delvare
Suse L3 Support

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors