Skip to contentSkip to conversation

sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

PATCH In review Kirill Tkhai 3 participants 3 messages Feb 25, 2014 – Feb 27, 2014 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

In deadline class we do not have group scheduling.

So, let's remove unnecessary

	X = X;

equations.

CC Juri Lelli <[email protected]>
CC Peter Zijlstra <[email protected]>
CC Ingo Molnar <[email protected]>
---
 kernel/sched/deadline.c |    2 --
 1 file changed, 2 deletions(-)
kernel/sched/deadline.c +0 -2
index ef96edc..2c28437 100644
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
 static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory--;
#1 lore raw
Quoted 9 lines · On Tue, 25 Feb 2014 19:52:23 +0400 Kirill Tkhai <[email protected]> wrote:

In deadline class we do not have group scheduling.

So, let's remove unnecessary

	X = X;

equations.

Thanks!

- Juri

Quoted 31 lines
CC Juri Lelli <[email protected]>
CC Peter Zijlstra <[email protected]>
CC Ingo Molnar <[email protected]>
---
 kernel/sched/deadline.c |    2 --
 1 file changed, 2 deletions(-)
kernel/sched/deadline.c +0 -2
index ef96edc..2c28437 100644
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
 static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory--;
#2 lore raw

[tip:sched/urgent] sched/deadline: Cleanup RT leftovers from {inc /dec}_dl_migration

In reply to Kirill Tkhai
sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration
Commit-ID:  3908ac13b550c93f97d8db136ff572be5495bc06
Gitweb:     http://git.kernel.org/tip/3908ac13b550c93f97d8db136ff572be5495bc06
Author:     Kirill Tkhai <[email protected]>
AuthorDate: Tue, 25 Feb 2014 19:52:23 +0400
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 27 Feb 2014 12:29:39 +0100

sched/deadline: Cleanup RT leftovers from {inc/dec}_dl_migration

In deadline class we do not have group scheduling.

So, let's remove unnecessary

	X = X;

equations.

---
 kernel/sched/deadline.c | 2 --
 1 file changed, 2 deletions(-)
kernel/sched/deadline.c +0 -2
index 15cbc17..aecf930 100644
@@ -135,7 +135,6 @@ static void update_dl_migration(struct dl_rq *dl_rq)
 static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory++;
@@ -146,7 +145,6 @@ static void inc_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 static void dec_dl_migration(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
 {
 	struct task_struct *p = dl_task_of(dl_se);
-	dl_rq = &rq_of_dl_rq(dl_rq)->dl;
 
 	if (p->nr_cpus_allowed > 1)
 		dl_rq->dl_nr_migratory--;