Modernize pm8921 with irqdomains, regmap, DT
v4 cover Modernize pm8921 with irqdomains, regmap, DT
These patches lay the groundwork for converting the pm8921 sub-devices to devicetree as well as simplify the API by migrating the core code to use the regmap API instead of the custom pm8xxx read/write wrapper.
Changes since v3:
* Added irqdomain Kconfig select
* New patch to loosen Kconfig on PM8921 config
* Picked up acked-by
Changes since v2:
* Picked up reviewed-by tags
* Fixed irqdomain teardown in driver remove
* No magical 256 constant
* Renamed domain to irqdomain
* Clarified kzalloc call
* Pushed ssbi regmap helpers into header file
* Fixed whitespace noise in patch 6
Changes since v1:
* First 3 cleanup patches dropped because they're applied upstream
* New regmap read/write helpers
* New patch for DT match table
* New binding document
Stephen Boyd (8):
mfd: Move pm8xxx-irq.c contents into only driver that uses it
mfd: pm8921: Update for genirq changes
mfd: pm8921: Migrate to irqdomains
mfd: ssbi: Add regmap read/write helpers
mfd: pm8921: Use ssbi regmap
mfd: pm8921: Add DT match table
mfd: pm8921: Loosen Kconfig dependency
devicetree: bindings: Document PM8921/8058 PMICs
.../devicetree/bindings/mfd/qcom,pm8xxx.txt | 63 +++ drivers/mfd/Kconfig | 15 +- drivers/mfd/Makefile | 1 - drivers/mfd/pm8921-core.c | 427 ++++++++++++++++++--- drivers/mfd/pm8xxx-irq.c | 371 ------------------ include/linux/mfd/pm8xxx/irq.h | 59 --- include/linux/mfd/pm8xxx/pm8921.h | 30 -- include/linux/ssbi.h | 20 + 8 files changed, 460 insertions(+), 526 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt delete mode 100644 drivers/mfd/pm8xxx-irq.c delete mode 100644 include/linux/mfd/pm8xxx/irq.h delete mode 100644 include/linux/mfd/pm8xxx/pm8921.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 1/8 mfd: Move pm8xxx-irq.c contents into only driver that uses it
The pm8xxx-irq.c code is practically mandatory given that the pm8921-core driver will WARN about it missing and the Kconfig marks it as default y when a PM8xxx chips is enabled. The only reason the file was split out was because we planned to support other pm8xxx chips with different pm8xxx-core.c files. Now that we have DT on ARM this isn't necessary because we should be able to support all the ssbi based PM8xxx chips in one driver and one file with no data bloat. Let's move this code into the only driver that uses it right now (pm8921) so that it's always compiled when needed. In the future we can rename pm8921-core.c to something more generic.
--- drivers/mfd/Kconfig | 10 -- drivers/mfd/Makefile | 1 - drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++ drivers/mfd/pm8xxx-irq.c | 371 ----------------------------------------- include/linux/mfd/pm8xxx/irq.h | 23 --- 5 files changed, 348 insertions(+), 405 deletions(-) delete mode 100644 drivers/mfd/pm8xxx-irq.c
drivers/mfd/Kconfig +0 -10
@@ -487,16 +487,6 @@ config MFD_PM8921_CORE Say M here if you want to include support for PM8921 chip as a module. This will build a module called "pm8921-core". -config MFD_PM8XXX_IRQ - bool "Qualcomm PM8xxx IRQ features" - depends on MFD_PM8XXX - default y if MFD_PM8XXX - help - This is the IRQ driver for Qualcomm PM 8xxx PMIC chips. - - This is required to use certain other PM 8xxx features, such as GPIO - and MPP. - config MFD_RDC321X tristate "RDC R-321x southbridge" select MFD_CORE
drivers/mfd/Makefile +0 -1
@@ -150,7 +150,6 @@ obj-$(CONFIG_MFD_SI476X_CORE) += si476x-core.o obj-$(CONFIG_MFD_CS5535) += cs5535-mfd.o obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o omap-usb-tll.o obj-$(CONFIG_MFD_PM8921_CORE) += pm8921-core.o ssbi.o -obj-$(CONFIG_MFD_PM8XXX_IRQ) += pm8xxx-irq.o obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o obj-$(CONFIG_MFD_TPS65090) += tps65090.o obj-$(CONFIG_MFD_AAT2870_CORE) += aat2870-core.o
drivers/mfd/pm8921-core.c +348 -0
369 lines not on this page · raw message
drivers/mfd/pm8xxx-irq.c deleted +0 -371
371 lines not on this page · raw message
include/linux/mfd/pm8xxx/irq.h +0 -23
@@ -33,27 +33,4 @@ struct pm8xxx_irq_platform_data { int irq_trigger_flag; }; -struct pm_irq_chip ; - -#ifdef CONFIG_MFD_PM8XXX_IRQ -int pm8xxx_get_irq_stat (struct pm_irq_chip *chip,int irq); -struct pm_irq_chip *pm8xxx_irq_init (struct device *dev, -const struct pm8xxx_irq_platform_data *pdata); -int pm8xxx_irq_exit (struct pm_irq_chip *chip); -#else -static inline int pm8xxx_get_irq_stat (struct pm_irq_chip *chip,int irq) -{ -return -ENXIO ; -} -static inline struct pm_irq_chip *pm8xxx_irq_init ( -const struct device *dev, -const struct pm8xxx_irq_platform_data *pdata) -{ -return ERR_PTR (-ENXIO ); -} -static inline int pm8xxx_irq_exit (struct pm_irq_chip *chip) -{ -return -ENXIO ; -} -#endif /* CONFIG_MFD_PM8XXX_IRQ */ #endif /* __MFD_PM8XXX_IRQ_H */
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 2/8 mfd: pm8921: Update for genirq changes
In reply to Stephen BoydSince this code has been marked broken for some time a few genirq tree wide changes weren't made. set_irq_wake() was renamed to irq_set_irq_wake() in commit a0cd9ca2b (genirq: Namespace cleanup, 2011-02-10) and commit 10a8c383 (irq: introduce entry and exit functions for chained handlers) introduced the chained irq functions but this driver wasn't updated to use them. Fix these problems and remove the BROKEN marking on this driver.
--- drivers/mfd/Kconfig | 1 - drivers/mfd/pm8921-core.c | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-)
drivers/mfd/Kconfig +0 -1
@@ -474,7 +474,6 @@ config MFD_PM8XXX config MFD_PM8921_CORE tristate "Qualcomm PM8921 PMIC chip" depends on (ARCH_MSM || HEXAGON) - depends on BROKEN select MFD_CORE select MFD_PM8XXX help
drivers/mfd/pm8921-core.c +5 -2
@@ -15,6 +15,7 @@#include <linux/kernel.h> #include <linux/interrupt.h> +#include <linux/irqchip/chained_irq.h> #include <linux/irq.h> #include <linux/module.h> #include <linux/platform_device.h>
@@ -174,6 +175,8 @@ static void pm8xxx_irq_handler(unsigned int irq, struct irq_desc *desc)u8 root;int i, ret, masters =0 ; +chained_irq_enter (irq_chip, desc); + ret =pm8xxx_read_root_irq (chip, &root);if (ret) {pr_err ("Can't read root status ret=%d\n" , ret);
@@ -188,7 +191,7 @@ static void pm8xxx_irq_handler(unsigned int irq, struct irq_desc *desc)if (masters & (1 << i))pm8xxx_irq_master_handler (chip, i); - irq_chip->irq_ack (&desc->irq_data); +chained_irq_exit (irq_chip, desc); }static void pm8xxx_irq_mask_ack (struct irq_data *d)
@@ -367,7 +370,7 @@ static struct pm_irq_chip *pm8xxx_irq_init(struct device *dev,irq_set_irq_type (devirq, pdata->irq_trigger_flag);irq_set_handler_data (devirq, chip);irq_set_chained_handler (devirq, pm8xxx_irq_handler); -set_irq_wake (devirq,1 ); +irq_set_irq_wake (devirq,1 );return chip; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 3/8 mfd: pm8921: Migrate to irqdomains
In reply to Stephen BoydConvert this driver to use irqdomains so that the PMIC's child devices can be converted to devicetree.
--- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 198 +++++++++++++++----------------------- include/linux/mfd/pm8xxx/irq.h | 36 ------- include/linux/mfd/pm8xxx/pm8921.h | 30 ------ 4 files changed, 76 insertions(+), 189 deletions(-) delete mode 100644 include/linux/mfd/pm8xxx/irq.h delete mode 100644 include/linux/mfd/pm8xxx/pm8921.h
drivers/mfd/Kconfig +1 -0
@@ -474,6 +474,7 @@ config MFD_PM8XXX config MFD_PM8921_CORE tristate "Qualcomm PM8921 PMIC chip" depends on (ARCH_MSM || HEXAGON) + select IRQ_DOMAIN select MFD_CORE select MFD_PM8XXX help
drivers/mfd/pm8921-core.c +75 -123
302 lines not on this page · raw message
include/linux/mfd/pm8xxx/irq.h deleted +0 -36
@@ -1,36 +0,0 @@ -/* -* Copyright (c) 2011, Code Aurora Forum. All rights reserved. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 and -* only version 2 as published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -*/ -/* -* Qualcomm PMIC irq 8xxx driver header file -* -*/ - -#ifndef __MFD_PM8XXX_IRQ_H -#define __MFD_PM8XXX_IRQ_H - -#include <linux/errno.h> -#include <linux/err.h> - -struct pm8xxx_irq_core_data { -u32 rev; -int nirqs; -}; - -struct pm8xxx_irq_platform_data { -int irq_base; -struct pm8xxx_irq_core_data irq_cdata; -int devirq; -int irq_trigger_flag; -}; - -#endif /* __MFD_PM8XXX_IRQ_H */
include/linux/mfd/pm8xxx/pm8921.h deleted +0 -30
@@ -1,30 +0,0 @@ -/* -* Copyright (c) 2011, Code Aurora Forum. All rights reserved. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License version 2 and -* only version 2 as published by the Free Software Foundation. -* -* This program is distributed in the hope that it will be useful, -* but WITHOUT ANY WARRANTY; without even the implied warranty of -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -* GNU General Public License for more details. -*/ -/* -* Qualcomm PMIC 8921 driver header file -* -*/ - -#ifndef __MFD_PM8921_H -#define __MFD_PM8921_H - -#include <linux/mfd/pm8xxx/irq.h> - -#define PM8921_NR_IRQS 256 - -struct pm8921_platform_data { -int irq_base; -struct pm8xxx_irq_platform_data *irq_pdata; -}; - -#endif
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 4/8 mfd: ssbi: Add regmap read/write helpers
In reply to Stephen BoydAdd read and write helper functions that the pm8921-core driver can use to read and write ssbi registers via a "no-bus" regmap.
--- include/linux/ssbi.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
include/linux/ssbi.h +20 -0
@@ -20,4 +20,24 @@int ssbi_write (struct device *dev,u16 addr,const u8 *buf,int len);int ssbi_read (struct device *dev,u16 addr,u8 *buf,int len); +static inline int +ssbi_reg_read (void *context,unsigned int reg,unsigned int *val) +{ +int ret; +u8 v; + + ret =ssbi_read (context, reg, &v,1 ); +if (!ret) + *val = v; + +return ret; +} + +static inline int +ssbi_reg_write (void *context,unsigned int reg,unsigned int val) +{ +u8 v = val; +return ssbi_write (context, reg, &v,1 ); +} +#endif
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 5/8 mfd: pm8921: Use ssbi regmap
In reply to Stephen BoydUse a regmap so that the pm8xxx read/write APIs can be removed once all consumer drivers are converted.
--- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 66 +++++++++++++++++++++++++++-------------------- 2 files changed, 39 insertions(+), 28 deletions(-)
drivers/mfd/Kconfig +1 -0
@@ -477,6 +477,7 @@ config MFD_PM8921_CORE select IRQ_DOMAIN select MFD_CORE select MFD_PM8XXX + select REGMAP help If you say yes to this option, support will be included for the built-in PM8921 PMIC chip.
drivers/mfd/pm8921-core.c +38 -28
180 lines not on this page · raw message
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 6/8 mfd: pm8921: Add DT match table
In reply to Stephen BoydAllow this driver to probe based on devicetree.
--- drivers/mfd/pm8921-core.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/mfd/pm8921-core.c +8 -0
@@ -392,6 +392,13 @@ static const struct regmap_config ssbi_regmap_config = { .reg_write = ssbi_reg_write }; +static const struct of_device_id pm8921_id_table[] = { + { .compatible ="qcom,pm8058" , }, + { .compatible ="qcom,pm8921" , }, + { } +}; +MODULE_DEVICE_TABLE (of, pm8921_id_table); +static int pm8921_probe (struct platform_device *pdev) {struct pm8921 *pmic;
@@ -501,6 +508,7 @@ static struct platform_driver pm8921_driver = { .driver = { .name = "pm8921-core", .owner = THIS_MODULE, + .of_match_table = pm8921_id_table, }, };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 7/8 mfd: pm8921: Loosen Kconfig dependency
In reply to Stephen BoydAllow this driver to be compiled on all ARM builds as it doesn't rely on anything within arm/mach-msm.
--- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
@@ -473,7 +473,7 @@ config MFD_PM8XXX config MFD_PM8921_CORE tristate "Qualcomm PM8921 PMIC chip" - depends on (ARCH_MSM || HEXAGON) + depends on (ARM || HEXAGON) select IRQ_DOMAIN select MFD_CORE select MFD_PM8XXX
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
PATCH v4 8/8 devicetree: bindings: Document PM8921/8058 PMICs
In reply to Stephen BoydPM8921 and PM8058 are PMICs found paired with MSM8960 and MSM8660 devices respectively. They contain subdevices such as keypads, RTC, regulators, clocks, etc.
--- .../devicetree/bindings/mfd/qcom,pm8xxx.txt | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt
Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt new file +63 -0
@@ -0,0 +1,63 @@ +Qualcomm PM8xxx PMIC multi-function devices + +PROPERTIES + +- compatible: + Usage: required + Value type: <string> + Definition: must be one of: + "qcom,pm8058" + "qcom,pm8921" + +- #address-cells: + Usage: required + Value type: <u32> + Definition: must be 1 + +- #size-cells: + Usage: required + Value type: <u32> + Definition: must be 0 + +- interrupts: + Usage: required + Value type: <prop-encoded-array> + Definition: specifies the interrupt that indicates a subdevice + has generated an interrupt (summary interrupt). The + format of the specifier is defined by the binding document + describing the node's interrupt parent. + +- #interrupt-cells: + Usage: required + Value type : <u32> + Definition: must be 2. Specifies the number of cells needed to encode + an interrupt source. The 1st cell contains the interrupt + number. The 2nd cell is the trigger type and level flags + encoded as follows: + + 1 = low-to-high edge triggered + 2 = high-to-low edge triggered + 4 = active high level-sensitive + 8 = active low level-sensitive + +- interrupt-controller: + Usage: required + Value type: <empty> + Definition: identifies this node as an interrupt controller + +EXAMPLE + + pmicintc: pmic at 0 { + compatible = "qcom,pm8921"; + interrupts = <104 8>; + #interrupt-cells = <2>; + interrupt-controller; + #address-cells = <1>; + #size-cells = <0>; + + pwrkey { + compatible = "qcom,pm8921-pwrkey"; + interrupt-parent = <&pmicintc>; + interrupts = <50 1>, <51 1>; + }; + };
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Lee Jones
AppliedRe: [PATCH v4 1/8] mfd: Move pm8xxx-irq.c contents into only driver that uses it
In reply to Stephen BoydQuoted 14 lines
The
pm8xxx-irq.ccode is practically mandatory given that the pm8921-core driver will WARN about it missing and theKconfigmarks it as default y when a PM8xxx chips is enabled. The only reason the file was split out was because we planned to support other pm8xxx chips with differentpm8xxx-core.cfiles. Now that we have DT on ARM this isn't necessary because we should be able to support all the ssbi based PM8xxx chips in one driver and one file with no data bloat. Let's move this code into the only driver that uses it right now (pm8921) so that it's always compiled when needed. In the future we can renamepm8921-core.cto something more generic.Acked-by Lee Jones <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 8 lines
--- drivers/mfd/Kconfig | 10 -- drivers/mfd/Makefile | 1 - drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++ drivers/mfd/pm8xxx-irq.c | 371 ----------------------------------------- include/linux/mfd/pm8xxx/irq.h | 23 --- 5 files changed, 348 insertions(+), 405 deletions(-) delete mode 100644 drivers/mfd/pm8xxx-irq.c
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 2/8] mfd: pm8921: Update for genirq changes
In reply to Stephen BoydQuoted 8 lines
Since this code has been marked broken for some time a few genirq tree wide changes weren't made.
set_irq_wake()was renamed toirq_set_irq_wake()in commita0cd9ca2b(genirq: Namespace cleanup, 2011-02-10) and commit10a8c383(irq: introduce entry and exit functions for chained handlers) introduced the chained irq functions but this driver wasn't updated to use them. Fix these problems and remove the BROKEN marking on this driver.
Quoted 6 lines
Acked-by Lee Jones <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/mfd/Kconfig | 1 - drivers/mfd/pm8921-core.c | 7 +++++-- 2 files changed, 5 insertions(+), 3 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 3/8] mfd: pm8921: Migrate to irqdomains
In reply to Stephen BoydQuoted 5 lines · Stephen Boyd
Convert this driver to use irqdomains so that the PMIC's child devices can be converted to devicetree.
Acked-by Lee Jones <[email protected]>Signed-off-by Stephen Boyd <[email protected]>
Quoted 8 lines
--- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 198 +++++++++++++++----------------------- include/linux/mfd/pm8xxx/irq.h | 36 ------- include/linux/mfd/pm8xxx/pm8921.h | 30 ------ 4 files changed, 76 insertions(+), 189 deletions(-) delete mode 100644 include/linux/mfd/pm8xxx/irq.h delete mode 100644 include/linux/mfd/pm8xxx/pm8921.h
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 4/8] mfd: ssbi: Add regmap read/write helpers
In reply to Stephen BoydQuoted 8 lines · Stephen Boyd
Add read and write helper functions that the pm8921-core driver can use to read and write ssbi registers via a "no-bus" regmap.
Cc Mark Brown <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- include/linux/ssbi.h | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 5/8] mfd: pm8921: Use ssbi regmap
In reply to Stephen BoydQuoted 9 lines · Stephen Boyd
Use a regmap so that the pm8xxx read/write APIs can be removed once all consumer drivers are converted.
Reviewed-by Mark Brown <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/mfd/Kconfig | 1 + drivers/mfd/pm8921-core.c | 66 +++++++++++++++++++++++++++-------------------- 2 files changed, 39 insertions(+), 28 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 6/8] mfd: pm8921: Add DT match table
In reply to Stephen BoydQuoted 7 lines · Stephen Boyd
Allow this driver to probe based on devicetree.
Acked-by Lee Jones <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/mfd/pm8921-core.c | 8 ++++++++ 1 file changed, 8 insertions(+)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Lee Jones
AppliedRe: [PATCH v4 7/8] mfd: pm8921: Loosen Kconfig dependency
In reply to Stephen BoydQuoted 7 lines · Stephen Boyd
Allow this driver to be compiled on all ARM builds as it doesn't rely on anything within arm/mach-msm.
Signed-off-by Stephen Boyd <[email protected]>--- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v4 8/8] devicetree: bindings: Document PM8921/8058 PMICs
In reply to Stephen BoydQuoted 10 lines
PM8921 and PM8058 are PMICs found paired with MSM8960 and MSM8660 devices respectively. They contain subdevices such as keypads, RTC, regulators, clocks, etc.
Cc <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- .../devicetree/bindings/mfd/qcom,pm8xxx.txt | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/qcom,pm8xxx.txt
This patch has been on the MLs for some time now and hasn't received any feedback from the DT guys.
Patch looks good (despite the lack IRQ defines), applied.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog