Skip to contentSkip to conversation

iio:adc:vf610 ensure correct handing of interruption of wait for completion

PATCH In review Jonathan Cameron 2 participants 3 messages Mar 1, 2014 – Mar 2, 2014

Subsystems (2)
IIO NXP i.MX 7D/6SX/6UL/93 and VF610 ADC driver
lore
Share & tools
lore

Jonathan Cameron

author maintainer
#0 lore raw

PATCH 1/1 iio:adc:vf610 ensure correct handing of interruption of wait for completion

Issue highlighted by smatch warning:

CHECK drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if interrupted, ret must be signed.

Signed-off-by Jonathan Cameron <[email protected]>
Cc Dan Carpenter <[email protected]>
Cc Fugang Duan <[email protected]>
---
 drivers/iio/adc/vf610_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/vf610_adc.c +1 -1
index 37f542e..44799eb5 100644
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,
 {
 	struct vf610_adc *info = iio_priv(indio_dev);
 	unsigned int hc_cfg;
-	unsigned long ret;
+	long ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
Signature · 1 line
1.9.0
Acked-by Fugang Duan on v1 1/1
#1 lore raw

From: Jonathan Cameron <[email protected]>
Data: Sunday, March 02, 2014 6:03 AM

Quoted 34 lines

To: [email protected]
Cc: Jonathan Cameron; Dan Carpenter; Duan Fugang-B38611
Subject: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

Issue highlighted by smatch warning:

CHECK drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if interrupted, ret must be signed.

Signed-off-by Jonathan Cameron <[email protected]>
Cc Dan Carpenter <[email protected]>
Cc Fugang Duan <[email protected]>

---
drivers/iio/adc/vf610_adc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/vf610_adc.c index renamed from drivers/iio/adc/vf610_adc.c +0 -0

37f542e..44799eb5 100644

drivers/iio/adc/vf610_adc.c +1 -2
@@ -447,7 +447,7 @@ static int vf610_read_raw(struct iio_dev *indio_dev,  {
 	struct vf610_adc *info = iio_priv(indio_dev);
 	unsigned int hc_cfg;
-	unsigned long ret;
+	long ret;
 
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
--
Quoted 3 lines

1.9.0

Acked-by Fugang Duan <[email protected]>
author maintainer Applied
#2 lore raw
Quoted 14 lines · On 02/03/14 01:36, [email protected] wrote:

From: Jonathan Cameron <[email protected]>
Data: Sunday, March 02, 2014 6:03 AM

Quoted 11 lines

To: [email protected]
Cc: Jonathan Cameron; Dan Carpenter; Duan Fugang-B38611
Subject: [PATCH] iio:adc:vf610 ensure correct handing of interruption of wait for completion

Issue highlighted by smatch warning:

CHECK drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:466 vf610_read_raw() warn: unsigned 'ret' is never less than zero.

Quoted 6 lines
Quoted 4 lines

As wait_for_completion_interruptible_timeout can return -ERESTARTSTSYS, if interrupted, ret must be signed.

Signed-off-by Jonathan Cameron <[email protected]>
Acked-by Fugang Duan <[email protected]>

Applied to the togreg branch of iio.git.