Skip to contentSkip to conversation

ip_set: remove extraneous log message

PATCH In review Jason A. Donenfeld 2 participants 2 messages Mar 2, 2014 – Mar 4, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ip_set: remove extraneous log message

This code path is hit everytime a new network namespace is created, which means it runs everytime I start Chromium, resulting in needless noise in my logs. This message doesn't add very much at all, and isn't triggered at the correct place anyway, so this patch simply removes it.

---
 net/netfilter/ipset/ip_set_core.c | 1 -
 1 file changed, 1 deletion(-)
net/netfilter/ipset/ip_set_core.c +0 -1
index de770ec..283f197 100644
@@ -1945,7 +1945,6 @@ ip_set_net_init(struct net *net)
 		return -ENOMEM;
 	inst->is_deleted = 0;
 	rcu_assign_pointer(inst->ip_set_list, list);
-	pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL);
 	return 0;
 }
 
Signature · 1 line
1.8.5.4
#1 lore raw
Quoted 15 lines · Jason A. Donenfeld

This code path is hit everytime a new network namespace is created, which means it runs everytime I start Chromium, resulting in needless noise in my logs. This message doesn't add very much at all, and isn't triggered at the correct place anyway, so this patch simply removes it.

---
 net/netfilter/ipset/ip_set_core.c | 1 -
 1 file changed, 1 deletion(-)
net/netfilter/ipset/ip_set_core.c +0 -0
index de770ec..283f197 100644

net/netfilter/ipset/ip_set_core.c ip_set_net_init(struct net *net) · line 1949

Quoted 6 lines
net/netfilter/ipset/ip_set_core.c +0 -1
@@ -1945,7 +1945,6 @@ ip_set_net_init(struct net *net)
 		return -ENOMEM;
 	inst->is_deleted = 0;
 	rcu_assign_pointer(inst->ip_set_list, list);
-	pr_notice("ip_set: protocol %u\n", IPSET_PROTOCOL);
 	return 0;
 }

A similar patch has already been applied to the ipset git tree and going to be submitted this week. Thanks your patch anyway.

Best regards,
Jozsef
-
E-mail : [email protected], [email protected] PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences

          H-1525 Budapest 114, POB. 49, Hungary