Skip to contentSkip to conversation

drm/i915/vlv: no MCHBAR on VLV

PATCH Applied Jesse Barnes 4 participants 6 messages Mar 3, 2014 – Mar 19, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/vlv: no MCHBAR on VLV

So don't try to allocate and program it, we're only fooling ourselves.

---
 drivers/gpu/drm/i915/i915_dma.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_dma.c +3 -0
index 7688abc..22f839b 100644
@@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
 	u32 temp;
 	bool enabled;
 
+	if (IS_VALLEYVIEW(dev))
+		return;
+
 	dev_priv->mchbar_need_disable = false;
 
 	if (IS_I915G(dev) || IS_I915GM(dev)) {
Signature · 1 line
1.7.9.5
#1 lore raw

Junxiao, can you add you reviewed-by to this patch?

Thanks,
Jesse

Quoted 22 lines · On Mon, 3 Mar 2014 14:27:57 -0800 Jesse Barnes <[email protected]>…

So don't try to allocate and program it, we're only fooling ourselves.

---
 drivers/gpu/drm/i915/i915_dma.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/i915_dma.c +3 -0
index 7688abc..22f839b 100644
@@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
 	u32 temp;
 	bool enabled;
 
+	if (IS_VALLEYVIEW(dev))
+		return;
+
 	dev_priv->mchbar_need_disable = false;
 
 	if (IS_I915G(dev) || IS_I915GM(dev)) {
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#2 lore raw

Hi Jesse,

I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.

Could you tell me how to add "reviewed by" to the patch?

Thanks,
Junxiao

-----Original Message-----
From: Jesse Barnes [mailto:[email protected]]
Sent: Wednesday, March 19, 2014 2:13 AM
To: Jesse Barnes
Cc: [email protected]; Chang, Junxiao
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV

Junxiao, can you add you reviewed-by to this patch?

Thanks,
Jesse

Quoted 13 lines · On Mon, 3 Mar 2014 14:27:57 -0800 Jesse Barnes <[email protected]>…

So don't try to allocate and program it, we're only fooling ourselves.

---
 drivers/gpu/drm/i915/i915_dma.c |    3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_dma.c index 7688abc..22f839b 100644

drivers/gpu/drm/i915/i915_dma.c intel_setup_mchbar(struct drm_device *dev) · line 1195

Quoted 9 lines
drivers/gpu/drm/i915/i915_dma.c +3 -0
@@ -1187,6 +1187,9 @@ intel_setup_mchbar(struct drm_device *dev)
 	u32 temp;
 	bool enabled;
 
+	if (IS_VALLEYVIEW(dev))
+		return;
+
 	dev_priv->mchbar_need_disable = false;
 
 	if (IS_I915G(dev) || IS_I915GM(dev)) {

--
Jesse Barnes, Intel Open Source Technology Center

maintainer
#3 lore raw
Quoted 5 lines · Junxiao

Hi Jesse,

I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.

Could you tell me how to add "reviewed by" to the patch?

Just reply here, with Reviewed-by: tag, and patckwork picks it up.

Dave.

Reviewed-by
#4 lore raw

Thanks,
Junxiao

-----Original Message-----
From: Dave Airlie [mailto:[email protected]]
Sent: Wednesday, March 19, 2014 10:32 AM
To: Chang, Junxiao
Cc: Jesse Barnes; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV

Quoted 5 lines · Junxiao

Hi Jesse,

I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.

Could you tell me how to add "reviewed by" to the patch?

Just reply here, with Reviewed-by: tag, and patckwork picks it up.

Dave.

#5 lore raw
Quoted 1 line · Junxiao

Queued for -next, thanks for the patch&review.
-Daniel

Quoted 25 lines

Thanks,
Junxiao

-----Original Message-----
From: Dave Airlie [mailto:[email protected]]
Sent: Wednesday, March 19, 2014 10:32 AM
To: Chang, Junxiao
Cc: Jesse Barnes; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vlv: no MCHBAR on VLV

Quoted 5 lines · Junxiao

Hi Jesse,

I just registered patchwork account in freedesktop.org, but I don't know how to add "reviewed by" to the patch http://patchwork.freedesktop.org/patch/21324/.

Could you tell me how to add "reviewed by" to the patch?

Just reply here, with Reviewed-by: tag, and patckwork picks it up.

Dave.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch