Signed-off-by: Andrey Belous <[email protected]>
PATCH 1/1 Signed-off-by: Andrey Belous <[email protected]>
Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value
--- meta/conf/distro/include/tclibc-uclibc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/distro/include/tclibc-uclibc.inc +1 -1
@@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" LIBCOVERRIDE = ":libc-uclibc" OVERRIDES .= "${LIBCOVERRIDE}" -PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc"
Signature · 1 line
1.9.0
meta/conf/distro/include/tclibc-uclibc.inc LIBCEXTENSION = "-uclibc" · line 11
Quoted 2 lines · Andrey Belous
meta/conf/distro/include/tclibc-uclibc.inc +1
-1-PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"
Why would you be including tclibc-uclibc.inc if you don't want to use uclibc?
p.
Hi Phil,
I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library
-Andrey
-----Original Message-----
From: Phil Blundell [mailto:[email protected]]
Sent: Tuesday, March 04, 2014 4:43 PM
To: Andrey Belous
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <[email protected]>
meta/conf/distro/include/tclibc-uclibc.inc LIBCEXTENSION = "-uclibc" · line 11
Quoted 2 lines · Andrey Belous
meta/conf/distro/include/tclibc-uclibc.inc +1
-1-PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"
Why would you be including tclibc-uclibc.inc if you don't want to use uclibc?
p.
Quoted 3 lines · Andrey Belous
Hi Phil,
I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library
OK so write a uclibc recipe for it and let it provide virtual/libc and, we can very well have multiple version of recipes, this is no different. Then use higher DEFAULT_PREFERENCE for your recipe.
Quoted 23 lines
-Andrey
-----Original Message-----
From: Phil Blundell [mailto:[email protected]]
Sent: Tuesday, March 04, 2014 4:43 PM
To: Andrey Belous
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <[email protected]>meta/conf/distro/include/tclibc-uclibc.inc LIBCEXTENSION = "-uclibc" · line 11
Quoted 2 lines · Andrey Belous
meta/conf/distro/include/tclibc-uclibc.inc +1
-1-PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"Why would you be including tclibc-uclibc.inc if you don't want to use uclibc?
p.
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Hi Khem,
Quoted 8 lines · Khem Raj
Quoted 3 lines · Andrey Belous
Hi Phil,
I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild libraryOK so write a uclibc recipe for it and let it provide virtual/libc and, we can very well have multiple version of recipes, this is no different. Then use higher
DEFAULT_PREFERENCEfor your recipe.
I still don't get it why in distro/include/tclibc-uclibc.inc we have
PREFERRED_PROVIDER_virtual/libc = "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc"
and in distro/include/tclibc-eglibc.inc, we have:
PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libintl ?= "eglibc" PREFERRED_PROVIDER_virtual/libc ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libc ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libc-locale ?= "eglibc-locale"
Is a specific reason why in the first case we use "=" and not "?=" like used everywhere else? This file is loaded last, so we have no chance to override the value. regardless of the actual reason, don't we need the change anyways?
Quoted 30 lines · Nicolas Dechesne
Hi Khem,
Quoted 8 lines · Khem Raj
Quoted 3 lines · Andrey Belous
Hi Phil,
I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild libraryOK so write a uclibc recipe for it and let it provide virtual/libc and, we can very well have multiple version of recipes, this is no different. Then use higher
DEFAULT_PREFERENCEfor your recipe.I still don't get it why in distro/include/tclibc-uclibc.inc we have
PREFERRED_PROVIDER_virtual/libc = "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc"
and in distro/include/tclibc-eglibc.inc, we have:
PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libiconv ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libintl ?= "eglibc" PREFERRED_PROVIDER_virtual/libc ?= "eglibc" PREFERRED_PROVIDER_virtual/nativesdk-libc ?= "nativesdk-eglibc" PREFERRED_PROVIDER_virtual/libc-locale ?= "eglibc-locale"
Quoted 4 lines
Is a specific reason why in the first case we use "=" and not "?=" like used everywhere else? This file is loaded last, so we have no chance to override the value. regardless of the actual reason, don't we need the change anyways?
I would think eglibc.inc should be fixed as well.
Fair enough. I also agree that these variables should at least be consistent, and if we're assigning everything else with ?= then there seems no reason for that one provider to be treated specially. So I think your patch is fine, though it might be a good idea to re-send it with a less messed up commit message if you didn't already do that.
p.
Quoted 22 lines · Andrey Belous
Hi Phil,
I have prebuild uclibc library that I would like to use, without that change I cannot force to use my prebuild library-Andrey
-----Original Message-----
From: Phil Blundell [mailto:[email protected]]
Sent: Tuesday, March 04, 2014 4:43 PM
To: Andrey Belous
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <[email protected]>meta/conf/distro/include/tclibc-uclibc.inc LIBCEXTENSION = "-uclibc" · line 11
Quoted 2 lines · Andrey Belous
meta/conf/distro/include/tclibc-uclibc.inc +1
-1-PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc"Why would you be including tclibc-uclibc.inc if you don't want to use uclibc?
p.
Quoted 1 line · Andrey Belous
Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value
The format of your commit message is backwards, you need to have a short message with the filename:
tclibc-uclibc: <short message>
<long message>
Also this kind of change is distro specific and could be in your distro specific information, don;'t you need to override more of what's in here if you are using a prebuilt library?
Sau!
Quoted 18 lines
--- meta/conf/distro/include/tclibc-uclibc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/conf/distro/include/tclibc-uclibc.inc +1
-1@@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" LIBCOVERRIDE = ":libc-uclibc" OVERRIDES .= "${LIBCOVERRIDE}" -PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc"
Yes I overwriting more , but other variable already with ?= and allow to override them
-Andrey
-----Original Message-----
From: Saul Wold [mailto:[email protected]]
Sent: Tuesday, March 04, 2014 6:05 PM
To: Andrey Belous; [email protected]
Subject: Re: [OE-core] [PATCH] Signed-off-by: Andrey Belous <[email protected]>
Quoted 1 line · Andrey Belous
Setting of a variable PREFERRED_PROVIDER_virtual/libc only if it doesn't have a value
The format of your commit message is backwards, you need to have a short message with the filename:
tclibc-uclibc: <short message>
<long message>
Also this kind of change is distro specific and could be in your distro specific information, don;'t you need to override more of what's in here if you are using a prebuilt library?
Sau!
Quoted 18 lines
--- meta/conf/distro/include/tclibc-uclibc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/conf/distro/include/tclibc-uclibc.inc +1
-1@@ -8,7 +8,7 @@ LIBCEXTENSION = "-uclibc" LIBCOVERRIDE = ":libc-uclibc" OVERRIDES .= "${LIBCOVERRIDE}" -PREFERRED_PROVIDER_virtual/libc = "uclibc" +PREFERRED_PROVIDER_virtual/libc ?= "uclibc" PREFERRED_PROVIDER_virtual/libiconv ?= "libiconv" PREFERRED_PROVIDER_virtual/libintl ?= "gettext" PREFERRED_PROVIDER_virtual/nativesdk-libintl ?= "nativesdk-eglibc"
Hi,
Quoted 1 line · Andrey Belous
Yes I overwriting more , but other variable already with ?= and allow to override them
I think I am okay with the patch proposed here. i don't see why the late assignment is missing just for this specific variable while it's used for every other variables and in the eglibc include file we already use the ?= for virtual/libc.
as far as I am concerned, assuming the commit log gets rewritten properly, you can add:
cheers,
nico