mfd: pm8921: fixup probe() error path when irq invalid
Subsystems (2)
PATCH 1/1 mfd: pm8921: fixup probe() error path when irq invalid
platform_get_irq() returns a negative error code when an IRQ is invalid or unspecified. Make 'irq' signed to properly handle this.
Cc Stephen Boyd <[email protected]>
Signed-off-by Josh Cartwright <[email protected]>
--- drivers/mfd/pm8921-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mfd/pm8921-core.c +1 -2
@@ -403,9 +403,8 @@ static int pm8921_probe(struct platform_device *pdev) {struct pm8921 *pmic;struct regmap *regmap; -int rc; +int irq, rc;unsigned int val; -unsigned int irq;u32 rev;struct pm_irq_chip *chip;unsigned int nirqs =PM8921_NR_IRQS ;
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 3 lines · Josh Cartwright
platform_get_irq()returns a negative error code when an IRQ is invalid or unspecified. Make 'irq' signed to properly handle this.
Reviewed-by Stephen Boyd <[email protected]>
Thanks
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
Quoted 8 lines
platform_get_irq()returns a negative error code when an IRQ is invalid or unspecified. Make 'irq' signed to properly handle this.Cc Stephen Boyd <[email protected]>Signed-off-by Josh Cartwright <[email protected]>--- drivers/mfd/pm8921-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Applied thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog