vmcore-dmesg stack smashing happend in extreme case
Subsystems (2)
PATCH v3 1/1 vmcore-dmesg stack smashing happend in extreme case
Description
in dump_dmesg_structured() the out_buf size is 4096, and if the length is less than 4080( 4096-16 ) it won't really write out. Normally, after writing one or four chars to the out_buf, it will check the length of out_buf. But in extreme cases, 19 chars was written to the out_buf before checking the length. This may cause the stack corruption. If the length was 4079 (won't realy write out), and then write 19 chars to it. the out_buf will overflow.
Solution
Change 16 to 64 thus can make sure that always have 64bytes before moving to next records. why using 64 is that a long long int can take 20 bytes. so the length of timestamp can be 44 ('[','.',']',' ') in extreme case.
--- vmcore-dmesg/vmcore-dmesg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
vmcore-dmesg/vmcore-dmesg.c +1 -1
@@ -674,7 +674,7 @@ static void dump_dmesg_structured(int fd)else out_buf[len++] = c; -if (len >=OUT_BUF_SIZE -16 ) { +if (len >=OUT_BUF_SIZE -64 ) {write_to_stdout (out_buf, len); len =0 ; }
Signature · 7 lines
1.8.4.2 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Simon Horman
AppliedQuoted 9 lines · Arthur Zou
Description
indump_dmesg_structured()theout_bufsize is 4096, and if the length is less than 4080( 4096-16 ) it won't really write out. Normally, after writing one or four chars to theout_buf, it will check the length ofout_buf. But in extreme cases, 19 chars was written to theout_bufbefore checking the length. This may cause the stack corruption. If the length was 4079 (won't realy write out), and then write 19 chars to it. theout_bufwill overflow.
Quoted 8 lines
Solution
Change 16 to 64 thus can make sure that always have 64bytes before moving to next records. why using 64 is that a long long int can take 20 bytes. so the length of timestamp can be 44 ('[','.',']',' ') in extreme case.Signed-off-by Arthur Zou <[email protected]>Acked-by Vivek Goyal <[email protected]>
Thanks, applied.
Quoted 20 lines
--- vmcore-dmesg/vmcore-dmesg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)vmcore-dmesg/vmcore-dmesg.c +1
-1@@ -674,7 +674,7 @@ static void dump_dmesg_structured(int fd)else out_buf[len++] = c; -if (len >=OUT_BUF_SIZE -16 ) { +if (len >=OUT_BUF_SIZE -64 ) {write_to_stdout (out_buf, len); len =0 ; }Signature · 1 line
1.8.4.2
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec