procfs: make smp_affinity values 0644

PATCH In review Chema Gonzalez 2 participants 3 messages Mar 14, 2014 IRQ

lore

Share & tools

lore

Chema Gonzalez

author

2014-03-14 02:07 UTC #0 lore raw

PATCH 1/1 procfs: make smp_affinity values 0644

Includes:
- /proc/irq/default_smp_affinity
- /proc/irq/*/smp_affinity
- /proc/irq/*/smp_affinity_list

Users can distill the same information by reading /proc/interrupts.

Signed-off-by Chema Gonzalez <[email protected]>

---
 kernel/irq/proc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

kernel/irq/proc.c +3 -3

index 36f6ee1..3f80a9a 100644
@@ -324,7 +324,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
 
 #ifdef CONFIG_SMP
 	/* create /proc/irq/<irq>/smp_affinity */
-	proc_create_data("smp_affinity", 0600, desc->dir,
+	proc_create_data("smp_affinity", 0644, desc->dir,
 			 &irq_affinity_proc_fops, (void *)(long)irq);
 
 	/* create /proc/irq/<irq>/affinity_hint */

@@ -332,7 +332,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc)
 			 &irq_affinity_hint_proc_fops, (void *)(long)irq);
 
 	/* create /proc/irq/<irq>/smp_affinity_list */
-	proc_create_data("smp_affinity_list", 0600, desc->dir,
+	proc_create_data("smp_affinity_list", 0644, desc->dir,
 			 &irq_affinity_list_proc_fops, (void *)(long)irq);
 
 	proc_create_data("node", 0444, desc->dir,

@@ -372,7 +372,7 @@ void unregister_handler_proc(unsigned int irq, struct irqaction *action)
 static void register_default_affinity_proc(void)
 {
 #ifdef CONFIG_SMP
-	proc_create("irq/default_smp_affinity", 0600, NULL,
+	proc_create("irq/default_smp_affinity", 0644, NULL,
 		    &default_affinity_proc_fops);
 #endif
 }

Signature · 1 line

1.9.0.279.gdc9e3eb

Eric Dumazet

2014-03-14 02:37 UTC #1 lore raw

Quoted 9 lines · Chema Gonzalez

Includes:
- /proc/irq/default_smp_affinity
- /proc/irq/*/smp_affinity
- /proc/irq/*/smp_affinity_list
Users can distill the same information by reading /proc/interrupts.
Signed-off-by Chema Gonzalez <[email protected]>
---

Seems good to me, but what about affinity_hint ?

Chema Gonzalez

author

2014-03-14 02:41 UTC #2 lore raw

0444 maybe?

-Chema

Quoted 14 lines · Eric Dumazet

Quoted 9 lines · Chema Gonzalez
Includes:
- /proc/irq/default_smp_affinity
- /proc/irq/*/smp_affinity
- /proc/irq/*/smp_affinity_list
Users can distill the same information by reading /proc/interrupts.
Signed-off-by Chema Gonzalez <[email protected]>
---
Seems good to me, but what about affinity_hint ?