Skip to contentSkip to conversation

staging: cxt1e1: hwprobe: Fix sparse warning

PATCH In review Matei Oprea 3 participants 6 messages Mar 18, 2014 – Mar 21, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: cxt1e1: hwprobe: Fix sparse warning

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19:
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1:
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1:
warning: symbol 'hdw_sn_get' was not declared. Should it be static? *drivers/staging/cxt1e1/hwprobe.c:149:1:
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1:
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1:
warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1:
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Cc ROSEdu Kernel Community <[email protected]>
---
 drivers/staging/cxt1e1/hwprobe.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/cxt1e1/hwprobe.c +7 -7
index 02b4f8f..694047a 100644
@@ -40,10 +40,10 @@ void        c4_stopwd (ci_t *);
 struct net_device * __init c4_add_dev (hdw_info_t *, int, unsigned long, unsigned long, int, int);
 
 
-struct s_hdw_info hdw_info[MAX_BOARDS];
+static struct s_hdw_info hdw_info[MAX_BOARDS];
 
 
-void        __init
+static void        __init
 show_two (hdw_info_t *hi, int brdno)
 {
     ci_t       *ci;
@@ -95,7 +95,7 @@ show_two (hdw_info_t *hi, int brdno)
 }
 
 
-void        __init
+static void        __init
 hdw_sn_get (hdw_info_t *hi, int brdno)
 {
     /* obtain hardware EEPROM information */
@@ -145,7 +145,7 @@ hdw_sn_get (hdw_info_t *hi, int brdno)
 }
 
 
-void        __init
+static void        __init
 prep_hdw_info (void)
 {
     hdw_info_t *hi;
@@ -165,7 +165,7 @@ prep_hdw_info (void)
     }
 }
 
-void
+static void
 cleanup_ioremap (void)
 {
     hdw_info_t *hi;
@@ -191,7 +191,7 @@ cleanup_ioremap (void)
 }
 
 
-void
+static void
 cleanup_devs (void)
 {
     hdw_info_t *hi;
@@ -289,7 +289,7 @@ c4_hdw_init (struct pci_dev *pdev, int found)
 }
 
 
-status_t    __init
+static status_t    __init
 c4hw_attach_all (void)
 {
     hdw_info_t *hi;
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 16 lines · Matei Oprea

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19:
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1:
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1:
warning: symbol 'hdw_sn_get' was not declared. Should it be static? *drivers/staging/cxt1e1/hwprobe.c:149:1:
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1:
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1:
warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1:
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Quoted 2 lines
Cc ROSEdu Kernel Community <[email protected]>

Why the cc: for a non-maintainer / person?

curious,

greg k-h

#2 lore raw
Quoted 4 lines
Quoted 2 lines
Cc ROSEdu Kernel Community <[email protected]>

Why the cc: for a non-maintainer / person?

We try to keep track of student's contributions in this way. Also, patches are internally reviewed on this mailing list before sending them to maintainers.

thanks,
Daniel.

maintainer
#3 lore raw
In reply to Matei Oprea
Quoted 7 lines · Matei Oprea

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19:
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1:
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1:
warning: symbol 'hdw_sn_get' was not declared. Should it be static?

Quoted 8 lines

*drivers/staging/cxt1e1/hwprobe.c:149:1:
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1:
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1:
warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1:
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Please don't line-wrap sparse or compiler warnings, it just looks messy.

maintainer
#4 lore raw
In reply to Matei Oprea

drivers/staging/cxt1e1/hwprobe.c show_two (hdw_info_t *hi, int brdno)

Quoted 40 lines · Matei Oprea

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19:
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1:
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1:
warning: symbol 'hdw_sn_get' was not declared. Should it be static? *drivers/staging/cxt1e1/hwprobe.c:149:1:
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1:
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1:
warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1:
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Cc ROSEdu Kernel Community <[email protected]>
---
 drivers/staging/cxt1e1/hwprobe.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/cxt1e1/hwprobe.c +2 -2
index 02b4f8f..694047a 100644
@@ -40,10 +40,10 @@ void        c4_stopwd (ci_t *);
 struct net_device * __init c4_add_dev (hdw_info_t *, int, unsigned long, unsigned long, int, int);
 
 
-struct s_hdw_info hdw_info[MAX_BOARDS];
+static struct s_hdw_info hdw_info[MAX_BOARDS];
 
 
-void        __init
+static void        __init
 show_two (hdw_info_t *hi, int brdno)
 {
     ci_t       *ci;
@@ -95,7 +95,7 @@ show_two (hdw_info_t *hi, int brdno)

This patch doesn't apply at all, did you do it against my staging-next branch of staging.git or linux-next? Or did you do it against Linus's tree? If Linus's tree, that's quite "old" for development stuff, always work against linux-next to avoid making the same changes others already have in the past.

greg k-h

#5 lore raw

I did it against your master branch of staging.git. I guess that's why doesn't apply at all. I switched branches to staging-next after your e-mail.

Thanks and sorry !

Quoted 50 lines · Greg KH

drivers/staging/cxt1e1/hwprobe.c show_two (hdw_info_t *hi, int brdno)

Quoted 40 lines · Matei Oprea

This fixes the following sparse warning:
* drivers/staging/cxt1e1/hwprobe.c:43:19:
warning: symbol 'hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:47:1:
warning: symbol 'show_two' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:99:1:
warning: symbol 'hdw_sn_get' was not declared. Should it be static? *drivers/staging/cxt1e1/hwprobe.c:149:1:
warning: symbol 'prep_hdw_info' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:169:1:
warning: symbol 'cleanup_ioremap' was not declared. Should it be static?
* drivers/staging/cxt1e1/hwprobe.c:195:1:
warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1:
* warning: symbol 'c4hw_attach_all' was not declared. Should it be static?

Cc ROSEdu Kernel Community <[email protected]>
---
 drivers/staging/cxt1e1/hwprobe.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/cxt1e1/hwprobe.c +2 -2
index 02b4f8f..694047a 100644
@@ -40,10 +40,10 @@ void        c4_stopwd (ci_t *);
 struct net_device * __init c4_add_dev (hdw_info_t *, int, unsigned long, unsigned long, int, int);
 
 
-struct s_hdw_info hdw_info[MAX_BOARDS];
+static struct s_hdw_info hdw_info[MAX_BOARDS];
 
 
-void        __init
+static void        __init
 show_two (hdw_info_t *hi, int brdno)
 {
     ci_t       *ci;
@@ -95,7 +95,7 @@ show_two (hdw_info_t *hi, int brdno)

This patch doesn't apply at all, did you do it against my staging-next branch of staging.git or linux-next? Or did you do it against Linus's tree? If Linus's tree, that's quite "old" for development stuff, always work against linux-next to avoid making the same changes others already have in the past.

greg k-h

Signature · 3 lines
Oprea Matei

ᐧ