tests/acpi-test: do not run iasl on big endian machines

PATCH Superseded Marcel Apfelbaum 2 participants 3 messages Mar 20, 2014

Share & tools

Marcel Apfelbaum

author

2014-03-20 17:47 UTC #0 lore raw

PATCH 1/1 tests/acpi-test: do not run iasl on big endian machines

There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables.

Do not run iasl on those machines until this problem is solved by the acpica community.

Signed-off-by Marcel Apfelbaum <[email protected]>

---
 tests/acpi-test.c | 2 ++
 1 file changed, 2 insertions(+)

tests/acpi-test.c +2 -0

index 249fe03..af44e47 100644
@@ -145,8 +145,10 @@ static uint8_t boot_sector[0x7e000] = {
 
 static const char *disk = "tests/acpi-test-disk.raw";
 static const char *data_dir = "tests/acpi-test-data";
+#if G_BYTE_ORDER == G_LITTLE_ENDIAN
 #ifdef CONFIG_IASL
 static const char *iasl = stringify(CONFIG_IASL);
+#endif
 #else
 static const char *iasl;
 #endif

Signature · 1 line

1.8.3.1

Peter Maydell

2014-03-20 19:01 UTC #1 lore raw

Quoted 6 lines · Marcel Apfelbaum

There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables.
Do not run iasl on those machines until this problem is solved by the acpica community.

Is there an upstream bug report for this? It would be nice to have a reference somewhere so we can tell if we can remove the check in future...

thanks
-- PMM

Marcel Apfelbaum

author

2014-03-20 19:08 UTC #2 lore raw

Quoted 11 lines · Peter Maydell

Quoted 6 lines · Marcel Apfelbaum
There is an issue with iasl on big endian machines: It cannot disassemble acpi tables taken from little endian machines, so we cannot check the expected tables.
Do not run iasl on those machines until this problem is solved by the acpica community.
Is there an upstream bug report for this? It would be nice to have a reference somewhere so we can tell if we can remove the check in future...

Hi Peter,
I opened a bug http://bugs.acpica.org/show_bug.cgi?id=1082 and
started a discussion https://lists.acpica.org/pipermail/devel/2014-March/000637.html

Thanks,
Marcel

Quoted 4 lines

thanks
-- PMM