Skip to contentSkip to conversation

cifs: Stop using NTLMSSP flag bit NTLMSSP_NEGOTIATE_EXTENDED_SEC for key exchange

PATCH New [email protected] 1 participant 1 message Mar 20, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 cifs: Stop using NTLMSSP flag bit NTLMSSP_NEGOTIATE_EXTENDED_SEC for key exchange

From: Shirish Pargaonkar <spargaonkar-IBi9RG/[email protected]>

Send EncryptedRandomSessionKey in an Authenticate message of NTLMSSP exchange based only on whether server set flag bit NTLMSSP_NEGOTIATE_KEY_EXCH in the Challenge message of the NTLMSSP exchange.

This is per section of MS-NLMP.
3.1.5.1.2 Client Receives a CHALLENGE_MESSAGE from the Server

---
 fs/cifs/sess.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/cifs/sess.c +1 -2
index e87387d..1bd6f4f 100644
@@ -450,8 +450,7 @@ int build_ntlmssp_auth_blob(unsigned char *pbuffer,
 	sec_blob->WorkstationName.MaximumLength = 0;
 	tmp += 2;
 
-	if (((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH) ||
-		(ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_EXTENDED_SEC))
+	if ((ses->ntlmssp->server_flags & NTLMSSP_NEGOTIATE_KEY_XCH)
 			&& !calc_seckey(ses)) {
 		memcpy(tmp, ses->ntlmssp->ciphertext, CIFS_CPHTXT_SIZE);
 		sec_blob->SessionKey.BufferOffset = cpu_to_le32(tmp - pbuffer);
Signature · 1 line
1.8.3.2