Skip to contentSkip to conversation

block: Use RCU_INIT_POINTER(x, NULL) in blk-cgroup.c

PATCH New Monam Agarwal 1 participant 1 message Mar 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Use RCU_INIT_POINTER(x, NULL) in blk-cgroup.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

Since rcu_assign_pointer() is to ensure that the initialization of a structure is carried out before storing a pointer to that structure. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL).

---
 block/blk-cgroup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/blk-cgroup.c +1 -1
index 4e491d9..fc62c47 100644
@@ -337,7 +337,7 @@ static void blkg_destroy(struct blkcg_gq *blkg)
 	 * will.  Hint assignment itself can race safely.
 	 */
 	if (rcu_dereference_raw(blkcg->blkg_hint) == blkg)
-		rcu_assign_pointer(blkcg->blkg_hint, NULL);
+		RCU_INIT_POINTER(blkcg->blkg_hint, NULL);
 
 	/*
 	 * If root blkg is destroyed.  Just clear the pointer since root_rl
Signature · 1 line
1.7.9.5