Skip to contentSkip to conversation

block: Use RCU_INIT_POINTER(x, NULL) in genhd.c

PATCH New Monam Agarwal 1 participant 1 message Mar 22, 2014 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Use RCU_INIT_POINTER(x, NULL) in genhd.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 block/genhd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
block/genhd.c +1 -1
index 791f419..3aec057 100644
@@ -1045,7 +1045,7 @@ static void disk_replace_part_tbl(struct gendisk *disk,
 	rcu_assign_pointer(disk->part_tbl, new_ptbl);
 
 	if (old_ptbl) {
-		rcu_assign_pointer(old_ptbl->last_lookup, NULL);
+		RCU_INIT_POINTER(old_ptbl->last_lookup, NULL);
 		kfree_rcu(old_ptbl, rcu_head);
 	}
 }
Signature · 1 line
1.7.9.5