Skip to contentSkip to conversation

kernel/sched: Use RCU_INIT_POINTER(x, NULL) in fair.c

PATCH New Monam Agarwal 1 participant 1 message Mar 23, 2014 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/sched: Use RCU_INIT_POINTER(x, NULL) in fair.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 kernel/sched/fair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
index 9b4c4f3..13b66aa 100644
@@ -1573,7 +1573,7 @@ void task_numa_free(struct task_struct *p)
 		list_del(&p->numa_entry);
 		grp->nr_tasks--;
 		spin_unlock(&grp->lock);
-		rcu_assign_pointer(p->numa_group, NULL);
+		RCU_INIT_POINTER(p->numa_group, NULL);
 		put_numa_group(grp);
 	}
 
Signature · 1 line
1.7.9.5