Skip to contentSkip to conversation

kernel: Use RCU_INIT_POINTER(x, NULL) in tracepoint.c

PATCH In review Monam Agarwal 2 participants 2 messages Mar 23, 2014 – Mar 24, 2014 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: Use RCU_INIT_POINTER(x, NULL) in tracepoint.c

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

---
 kernel/tracepoint.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/tracepoint.c +1 -1
index 031cc56..72dfa96 100644
@@ -291,7 +291,7 @@ static void disable_tracepoint(struct tracepoint *elem)
 
 	if (static_key_enabled(&elem->key))
 		static_key_slow_dec(&elem->key);
-	rcu_assign_pointer(elem->funcs, NULL);
+	RCU_INIT_POINTER(elem->funcs, NULL);
 }
 
 /**
Signature · 1 line
1.7.9.5
#1 lore raw

----- Original Message -----

Quoted 6 lines

From: "Monam Agarwal" <[email protected]>
To: "mathieu desnoyers" <[email protected]>, [email protected], "keun-o park" <[email protected]>, [email protected]
Sent: Sunday, March 23, 2014 3:09:08 PM
Subject: [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in tracepoint.c

Quoted 8 lines

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

This change makes sense. However, it would conflict with the changes I'm proposing for 3.15, which are making this patch obsolete. This would cause merging headaches for Steven. So it's his call.

Thanks,

Mathieu

Quoted 23 lines
---
 kernel/tracepoint.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/tracepoint.c +1 -2
index 031cc56..72dfa96 100644
@@ -291,7 +291,7 @@ static void disable_tracepoint(struct tracepoint *elem)
 
 	if (static_key_enabled(&elem->key))
 		static_key_slow_dec(&elem->key);
-	rcu_assign_pointer(elem->funcs, NULL);
+	RCU_INIT_POINTER(elem->funcs, NULL);
 }
 
 /**
--

1.7.9.5

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com