drivers/crypto: Use RCU_INIT_POINTER(x, NULL) in nx/nx-842.c
Subsystems (3)
PATCH 1/1 drivers/crypto: Use RCU_INIT_POINTER(x, NULL) in nx/nx-842.c
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)
--- drivers/crypto/nx/nx-842.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/nx/nx-842.c +2 -2
@@ -1234,7 +1234,7 @@ static int __exit nx842_remove(struct vio_dev *viodev) old_devdata =rcu_dereference_check (devdata,lockdep_is_held (&devdata_mutex));of_reconfig_notifier_unregister (&nx842_of_nb); -rcu_assign_pointer (devdata,NULL ); +RCU_INIT_POINTER (devdata,NULL );spin_unlock_irqrestore (&devdata_mutex, flags);synchronize_rcu ();dev_set_drvdata (&viodev->dev,NULL );
@@ -1285,7 +1285,7 @@ static void __exit nx842_exit(void)spin_lock_irqsave (&devdata_mutex, flags); old_devdata =rcu_dereference_check (devdata,lockdep_is_held (&devdata_mutex)); -rcu_assign_pointer (devdata,NULL ); +RCU_INIT_POINTER (devdata,NULL );spin_unlock_irqrestore (&devdata_mutex, flags);synchronize_rcu ();if (old_devdata)
Signature · 1 line
1.7.9.5
Herbert Xu
maintainerQuoted 8 lines · Monam Agarwal
This patch replaces
rcu_assign_pointer(x, NULL)withRCU_INIT_POINTER(x, NULL)The
rcu_assign_pointer()ensures that the initialization of a structure is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there is no structure to initialize. So,rcu_assign_pointer(p, NULL)can be safely converted toRCU_INIT_POINTER(p, NULL)Signed-off-by Monam Agarwal <[email protected]>
Patch applied.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt