Skip to contentSkip to conversation

use MTRR for write combining if PAT is not available

RFC PATCH Thomas Schlichter 1 participant 1 message Oct 22, 2009

lore
Share & tools
lore
#0 lore raw
Quoted 5 lines · Suresh Siddha
Quoted 4 lines · H. Peter Anvin
Quoted 2 lines · Thomas Schlichter

And in that case (shared "struct file", one single release() call in the end) this implementation should be completely safe...

Quoted 7 lines
Quoted 1 line

struct file is shared between forked processes.

That is correct. But I am referring to the ref-count getting incremented in Thomas's patch only in the pci_mmap_page_range() which will be called only during first mmap.

We need to keep track of the counts of later forks too.

When forked processes do mmap() PCI additional memory, pci_mmap_page_range() will be called again and the corresponding (shared) mtrr_usage_count wil be incremented. So we do keep track of later forks...

Yes, the MTRR reference count has nothing to do with the processes using this memory, but if you want this, arch/x86/kernel/cpu/mtrr/if.c must be changed, too.

Regards,
Thomas