Skip to contentSkip to conversation

Btrfs: check for an extent_op on the locked ref

PATCH New Josef Bacik 1 participant 1 message Mar 27, 2014 Btrfs file system

lore
Share & tools
lore

Josef Bacik

author
#0 lore raw

PATCH 1/1 Btrfs: check for an extent_op on the locked ref

We could have possibly added an extent_op to the locked_ref while we dropped locked_ref->lock, so check for this case as well and loop around. Otherwise we could lose flag updates which would lead to extent tree corruption. Thanks,

cc [email protected]
Signed-off-by Josef Bacik <[email protected]>
---
 fs/btrfs/extent-tree.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/btrfs/extent-tree.c +2 -1
index a050e83..af5a656 100644
@@ -2448,7 +2448,8 @@ static noinline int __btrfs_run_delayed_refs(struct btrfs_trans_handle *trans,
 			spin_unlock(&locked_ref->lock);
 			spin_lock(&delayed_refs->lock);
 			spin_lock(&locked_ref->lock);
-			if (rb_first(&locked_ref->ref_root)) {
+			if (rb_first(&locked_ref->ref_root) ||
+			    locked_ref->extent_op) {
 				spin_unlock(&locked_ref->lock);
 				spin_unlock(&delayed_refs->lock);
 				continue;
Signature · 1 line
1.8.3.1