am335x_evm: Clarify when we build board_eth_init
PATCH 1/1 am335x_evm: Clarify when we build board_eth_init
If we build this function in cases where we would be discarding it anyhow we still end up with maybe unused warnings. Rather than litter the function with __maybe_unused, just spell out when to build it.
Signed-off-by Tom Rini <[email protected]>
--- board/ti/am335x/board.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
board/ti/am335x/board.c +16 -2
@@ -573,8 +573,22 @@ static struct cpsw_platform_data cpsw_data = { };#endif -#if defined(CONFIG_DRIVER_TI_CPSW ) || \ - (defined(CONFIG_USB_ETHER ) && defined(CONFIG_MUSB_GADGET )) +/* +* This function will: +* Read the eFuse for MAC addresses, and set ethaddr/eth1addr/usbnet_devaddr +* in the environment +* Perform fixups to the PHY present on certain boards. We only need this +* function in: +* - SPL with either CPSW or USB ethernet support +* - Full U-Boot, with either CPSW or USB ethernet +* Build in only these cases to avoid warnings about unused variables +* when we build an SPL that has neither option but full U-Boot will. +*/ +#if ((defined(CONFIG_SPL_ETH_SUPPORT ) || defined(CONFIG_SPL_USBETH_SUPPORT )) \ + && defined(CONFIG_SPL_BUILD )) || \ + ((defined(CONFIG_DRIVER_TI_CPSW ) || \ + defined(CONFIG_USB_ETHER ) && defined(CONFIG_MUSB_GADGET )) && \ + !defined(CONFIG_SPL_BUILD ))int board_eth_init (bd_t *bis) {int rv, n =0 ;
Signature · 1 line
1.7.9.5
Quoted 5 lines · Tom Rini
If we build this function in cases where we would be discarding it anyhow we still end up with maybe unused warnings. Rather than litter the function with
__maybe_unused, just spell out when to build it.Signed-off-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140328/c870ea35/attachment.pgp>