Skip to contentSkip to conversation

spi: omap-100k: Fix memory leak

PATCH Applied Axel Lin 2 participants 2 messages Mar 29, 2014 SPI

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 spi: omap-100k: Fix memory leak

The memory allocated for cs is not freed anywhere. Convert to use devm_kzalloc to fix the memory leak.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/spi/spi-omap-100k.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-omap-100k.c +1 -1
index c9e2282..e7ffcde 100644
@@ -283,7 +283,7 @@ static int omap1_spi100k_setup(struct spi_device *spi)
 	spi100k = spi_master_get_devdata(spi->master);
 
 	if (!cs) {
-		cs = kzalloc(sizeof(*cs), GFP_KERNEL);
+		cs = devm_kzalloc(&spi->dev, sizeof(*cs), GFP_KERNEL);
 		if (!cs)
 			return -ENOMEM;
 		cs->base = spi100k->base + spi->chip_select * 0x14;
Signature · 8 lines
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Applied
#1 lore raw
Quoted 2 lines · Axel Lin

The memory allocated for cs is not freed anywhere. Convert to use devm_kzalloc to fix the memory leak.

Applied, thanks.