Skip to contentSkip to conversation

spi: bitbang: Make spi_bitbang_stop() return void

PATCH Applied Axel Lin 3 participants 3 messages Mar 29, 2014 – Mar 31, 2014 SPI

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 spi: bitbang: Make spi_bitbang_stop() return void

spi_bitbang_stop() never fails, so make it return void.

Signed-off-by Axel Lin <[email protected]>

---
v2: also update the code for drivers/spi/spi-butterfly.c. Note, spi-sh-msiof.c does use bitbang now.

 drivers/spi/spi-bitbang.c       | 4 +---
 drivers/spi/spi-butterfly.c     | 3 +--
 drivers/spi/spi-gpio.c          | 5 ++---
 drivers/spi/spi-omap-uwire.c    | 5 ++---
 include/linux/spi/spi_bitbang.h | 2 +-
 5 files changed, 7 insertions(+), 12 deletions(-)
drivers/spi/spi-bitbang.c +1 -3
index 3bfdb85..dc7d2c2 100644
@@ -466,11 +466,9 @@ EXPORT_SYMBOL_GPL(spi_bitbang_start);
 /**
  * spi_bitbang_stop - stops the task providing spi communication
  */
-int spi_bitbang_stop(struct spi_bitbang *bitbang)
+void spi_bitbang_stop(struct spi_bitbang *bitbang)
 {
 	spi_unregister_master(bitbang->master);
-
-	return 0;
 }
 EXPORT_SYMBOL_GPL(spi_bitbang_stop);
drivers/spi/spi-butterfly.c +1 -2
index 8081f96..ee4f91c 100644
@@ -309,7 +309,6 @@ done:
 static void butterfly_detach(struct parport *p)
 {
 	struct butterfly	*pp;
-	int			status;
 
 	/* FIXME this global is ugly ... but, how to quickly get from
 	 * the parport to the "struct butterfly" associated with it?

@@ -321,7 +320,7 @@ static void butterfly_detach(struct parport *p)
 	butterfly = NULL;
 
 	/* stop() unregisters child devices too */
-	status = spi_bitbang_stop(&pp->bitbang);
+	spi_bitbang_stop(&pp->bitbang);
 
 	/* turn off VCC */
 	parport_write_data(pp->port, 0);
drivers/spi/spi-gpio.c +2 -3
index 406bbd7..0982307 100644
@@ -502,13 +502,12 @@ static int spi_gpio_remove(struct platform_device *pdev)
 {
 	struct spi_gpio			*spi_gpio;
 	struct spi_gpio_platform_data	*pdata;
-	int				status;
 
 	spi_gpio = platform_get_drvdata(pdev);
 	pdata = dev_get_platdata(&pdev->dev);
 
 	/* stop() unregisters child devices too */
-	status = spi_bitbang_stop(&spi_gpio->bitbang);
+	spi_bitbang_stop(&spi_gpio->bitbang);
 
 	if (SPI_MISO_GPIO != SPI_GPIO_NO_MISO)
 		gpio_free(SPI_MISO_GPIO);

@@ -517,7 +516,7 @@ static int spi_gpio_remove(struct platform_device *pdev)
 	gpio_free(SPI_SCK_GPIO);
 	spi_master_put(spi_gpio->bitbang.master);
 
-	return status;
+	return 0;
 }
 
 MODULE_ALIAS("platform:" DRIVER_NAME);
drivers/spi/spi-omap-uwire.c +2 -3
index 31ce92f..be2a2e1 100644
@@ -516,14 +516,13 @@ static int uwire_probe(struct platform_device *pdev)
 static int uwire_remove(struct platform_device *pdev)
 {
 	struct uwire_spi	*uwire = platform_get_drvdata(pdev);
-	int			status;
 
 	// FIXME remove all child devices, somewhere ...
 
-	status = spi_bitbang_stop(&uwire->bitbang);
+	spi_bitbang_stop(&uwire->bitbang);
 	uwire_off(uwire);
 	iounmap(uwire_base);
-	return status;
+	return 0;
 }
 
 /* work with hotplug and coldplug */
include/linux/spi/spi_bitbang.h +1 -1
index daebaba..85578d4 100644
@@ -42,6 +42,6 @@ extern int spi_bitbang_setup_transfer(struct spi_device *spi,
 
 /* start or stop queue processing */
 extern int spi_bitbang_start(struct spi_bitbang *spi);
-extern int spi_bitbang_stop(struct spi_bitbang *spi);
+extern void spi_bitbang_stop(struct spi_bitbang *spi);
 
 #endif	/* __SPI_BITBANG_H */
Signature · 8 lines
1.8.3.2



--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Applied
#1 lore raw
Quoted 1 line · Axel Lin

spi_bitbang_stop() never fails, so make it return void.

Applied, thanks.

#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 6 lines · Axel Lin

spi_bitbang_stop() never fails, so make it return void.

Signed-off-by Axel Lin <[email protected]>

---
v2: also update the code for drivers/spi/spi-butterfly.c. Note, spi-sh-msiof.c does use bitbang now.

I guess you meant "does not"?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html