Skip to contentSkip to conversation

mmc: card.h: Use NULL instead of 0 for END_FIXUP

PATCH In review Fabio Estevam 3 participants 3 messages Apr 5, 2014 – Apr 9, 2014 MMC, SD and SDIO

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mmc: card.h: Use NULL instead of 0 for END_FIXUP

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer

drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer

Signed-off-by Fabio Estevam <[email protected]>
---
 include/linux/mmc/card.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mmc/card.h +1 -1
index b730272..aa7e57f 100644
@@ -353,7 +353,7 @@ struct mmc_fixup {
 #define CID_OEMID_ANY ((unsigned short) -1)
 #define CID_NAME_ANY (NULL)
 
-#define END_FIXUP { 0 }
+#define END_FIXUP { NULL }
 
 #define _FIXUP_EXT(_name, _manfid, _oemid, _rev_start, _rev_end,	\
 		   _cis_vendor, _cis_device,				\
Signature · 1 line
1.8.3.2
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer

drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Ulf Hansson <[email protected]>
Quoted 20 lines
---
 include/linux/mmc/card.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mmc/card.h +1 -2
index b730272..aa7e57f 100644
@@ -353,7 +353,7 @@ struct mmc_fixup {
 #define CID_OEMID_ANY ((unsigned short) -1)
 #define CID_NAME_ANY (NULL)
 
-#define END_FIXUP { 0 }
+#define END_FIXUP { NULL }
 
 #define _FIXUP_EXT(_name, _manfid, _oemid, _rev_start, _rev_end,       \
                   _cis_vendor, _cis_device,                            \
--

1.8.3.2

#2 lore raw
Quoted 25 lines · Ulf Hansson
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Fix the following sparse warnings:

drivers/mmc/card/block.c:2421:9: warning: Using plain integer as NULL pointer

drivers/mmc/core/quirks.c:69:9: warning: Using plain integer as NULL pointer

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Ulf Hansson <[email protected]>
Quoted 12 lines
---
  include/linux/mmc/card.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mmc/card.h +0 -0
index b730272..aa7e57f 100644
@@ -353,7 +353,7 @@ struct mmc_fixup {
  #define CID_OEMID_ANY ((unsigned short) -1)
  #define CID_NAME_ANY (NULL)
Quoted 2 lines

include/linux/mmc/card.h struct mmc_fixup { · line 356

Quoted 2 lines
include/linux/mmc/card.h +1 -1
-#define END_FIXUP { 0 }
+#define END_FIXUP { NULL }

It would also be possible to use { } here.

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius