Skip to contentSkip to conversation

staging/line6: Fix kzalloc coding style issue

PATCH In review L. Alberto Giménez 1 participant 2 messages Apr 6, 2014 – Apr 7, 2014 1 message not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging/line6: Fix kzalloc coding style issue

Pass the actual variable to sizeof instead of a type definition.

---
 drivers/staging/line6/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/line6/pcm.c +1 -1
index 661080b..a3136b1 100644
@@ -475,7 +475,7 @@ int line6_init_pcm(struct usb_line6 *line6,
 		MISSING_CASE;
 	}
 
-	line6pcm = kzalloc(sizeof(struct snd_line6_pcm), GFP_KERNEL);
+	line6pcm = kzalloc(sizeof(*line6pcm), GFP_KERNEL);
 
 	if (line6pcm == NULL)
 		return -ENOMEM;
Signature · 1 line
1.9.1

A message that is not in the archive (sent off-list or not yet received): s5hmwfxd69b.wl%[email protected]

#2 lore raw
Quoted 5 lines · Takashi Iwai

At Mon, 7 Apr 2014 00:12:30 +0200,

Quoted 3 lines · L. Alberto Giménez

Pass the actual variable to sizeof instead of a type definition.

Quoted 8 lines
Quoted 1 line

BTW, does anyone work on line6 stuff actively?
It's been in staging forever, and it's difficult to promote to the standard ALSA driver unless testing with the real hardware by some motivated person...

I'm Not sure of that. I think that development has somewhat stalled. I have line6 hardware that at the moment is not supported (HD500), and I would like to take the shot. But the problem is that there are no specs, and Line6 won't release any (I asked, several times, even offering to accept some kind of stupid NDA). So I would need to reverse engineer Windows drivers, and I don't have the knowledge to interpret captured USB traffic, so I'm stuck as well.

I'll try to revive the line6-devel mailing list sending some traffic captures and see if anyone can help or point me in the right direction. I would like to see my HD500 running natively on Linux, and it's a nice challenge to actually do some useful work for the kernel :)

Regards,
L. Alberto Giménez

P.S.: I sent this mail this morning from an alternative machine, and it seems that the mail configuration was broken. Resending, sorry if you received this message twice.