spi: efm32: Make "efm32,location" property optional
Subsystems (2)
RFC PATCH 1/1 spi: efm32: Make "efm32,location" property optional
The spi driver still works even if "efm32,location" property is not provided. Thus make "efm32,location" property optional.
Signed-off-by Axel Lin <[email protected]>
--- Documentation/devicetree/bindings/spi/efm32-spi.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/spi/efm32-spi.txt +2 -0
@@ -8,6 +8,8 @@ Required properties: - interrupts: pair specifying rx and tx irq - clocks: phandle to the spi clock - cs-gpios: see spi-bus.txt + +Recommended properties : - efm32,location: Value to write to the ROUTE register's LOCATION bitfield to configure the pinmux for the device, see datasheet for values. Example:
Signature · 8 lines
1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Axel,
Quoted 2 lines · Axel Lin
The spi driver still works even if "efm32,location" property is not provided. Thus make "efm32,location" property optional.
good catch. The changelog is wrong though. You don't make the property optional, you only adapt the documentation to reality. It would be also nice to mention the default value (i.e. keeping what is already configured in the hardware, so its either the reset default 0 or whatever the bootloader did.) OTOH I'm not sure if that should go into the binding doc as it sounds Linux specific?
Best regards
Uwe
Signature · 6 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html