Skip to contentSkip to conversation

xfstest: log operations properly to generic/001.full

PATCH New Ming Chen 1 participant 1 message Apr 9, 2014

lore
Share & tools
lore

Ming Chen

author
#0 lore raw

PATCH v2 1/1 xfstest: log operations properly to generic/001.full

Part of the operations were written to 001.full from the awk script, while the rest were piped to 001.full using tee. The resultant 001.full did not reflect what are really performed. This makes debugging difficult. The output of executing 001.full is discarded.

---
 tests/generic/001 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
tests/generic/001 +4 -4
index 6e5f3dd..6a10810 100755
@@ -190,7 +190,7 @@ _mark_iteration()
 #
 _chain()
 {
-    $AWK_PROG -v full_file=$seqres.full -v verify=$verify <$tmp.config '
+    $AWK_PROG -v verify=$verify <$tmp.config '
 BEGIN	{ nfile = 0 }
 /^\#/	{ next }
 	{ file[nfile] = $1
@@ -210,7 +210,7 @@ END	{ srand('$iter')
 		printf "if [ ! -f %s ]; then echo \"%s missing!\"; exit; fi\n",file[j],file[j]
 		printf "if [ -f %s.0 ]; then echo \"%s.0 already present!\"; exit; fi\n",file[j],file[j]
 		printf "cp %s %s.0 || exit 1\n",file[j],file[j]
-		printf "ls -i %s.0\n", file[j] >full_file;
+		printf "ls -i %s.0 > /dev/null\n", file[j];
 		total_size += size[j]
 		printf "# total size = %d\n", total_size 
 	    }
@@ -219,7 +219,7 @@ END	{ srand('$iter')
 		printf "if [ ! -f %s.%d ]; then echo \"%s.%d missing!\"; exit; fi\n",file[j],link[j]-1,file[j],link[j]-1
 		printf "if [ -f %s.%d ]; then echo \"%s.%d already present!\"; exit; fi\n",file[j],link[j],file[j],link[j]
 		printf "cp %s.%d %s.%d || exit 1\n",file[j],link[j]-1,file[j],link[j]
-		printf "ls -i %s.%d\n", file[j], link[j] >full_file;
+		printf "ls -i %s.%d > /dev/null\n", file[j], link[j];
 		total_size += size[j]
 		printf "# total size = %d\n", total_size 
 	    }
@@ -231,7 +231,7 @@ END	{ srand('$iter')
 	  for (j=0; j<nfile; j++) {
 	    if (link[j] > 0) {
 		printf "mv %s.%d %s.last\n",file[j],link[j]-1,file[j]
-		printf "ls -i %s.last\n", file[j] >full_file;
+		printf "ls -i %s.last > /dev/null\n", file[j];
 	    }
 	    for (i=0; i<link[j]-1; i++) {
 		printf "rm -f %s.%d\n",file[j],i
Signature · 6 lines
1.8.4.2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs