Skip to contentSkip to conversation

ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

PATCH Superseded Tim Gardner 2 participants 2 messages Apr 10, 2014 – Apr 11, 2014 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

The kerneloops-daemon scans dmesg for common crash signatures, among which is 'BUG:'. The message emitted by the PCM library is really a warning, so the most expedient thing to do seems to be to change the string.

Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>
Cc Mark Brown <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc JongHo Kim <[email protected]>
---
 sound/core/pcm_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_lib.c +1 -1
index ce83def..2a0563d 100644
@@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
 			snd_pcm_debug_name(substream, name, sizeof(name));
 			xrun_log_show(substream);
 			pcm_err(substream->pcm,
-				"BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
+				"OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
 				name, pos, runtime->buffer_size,
 				runtime->period_size);
 		}
Signature · 1 line
1.7.9.5
#1 lore raw

At Thu, 10 Apr 2014 10:45:08 -0600,

Quoted 23 lines · Tim Gardner

The kerneloops-daemon scans dmesg for common crash signatures, among which is 'BUG:'. The message emitted by the PCM library is really a warning, so the most expedient thing to do seems to be to change the string.

Cc Jaroslav Kysela <[email protected]>
Cc Takashi Iwai <[email protected]>
Cc Mark Brown <[email protected]>
Cc Lars-Peter Clausen <[email protected]>
Cc JongHo Kim <[email protected]>
---
 sound/core/pcm_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_lib.c +0 -0
index ce83def..2a0563d 100644

sound/core/pcm_lib.c static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream, · line 348

Quoted 5 lines
sound/core/pcm_lib.c +1 -1
@@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
 			snd_pcm_debug_name(substream, name, sizeof(name));
 			xrun_log_show(substream);
 			pcm_err(substream->pcm,
-				"BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
+				"OVER RUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",

Use a term "XRUN", as it's not always an overrun.

thanks,

Takashi