Skip to contentSkip to conversation

kernel:acct:spaces required

PATCH In review Paul McQuade 2 participants 2 messages Apr 10, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 11/15 kernel:acct:spaces required

ERROR: spaces required around that '>' (ctx:VxV)

---
 kernel/acct.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/acct.c +1 -1
index df28519..3fdafa9 100644
@@ -134,7 +134,7 @@ static int check_free_space(struct bsd_acct_struct *acct, struct file *file)
 	spin_lock(&acct_lock);
 	if (file != acct->file) {
 		if (act)
-			res = act>0;
+			res = act > 0;
 		goto out;
 	}
 
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 1 line · Paul McQuade

ERROR: spaces required around that '>' (ctx:VxV)

Egads, man...

a) ERROR (in ALL CAPS, no less) according to whom? Sure, it's nicer to add those spaces, but do you really think that it deserves a separate patch, especially with such a commit message?

b) AFAICS, you've posted at least 4 such one-liners to kernel/acct.c, with commit messages that sound like "Because The Most Holy sendpatch.pl (All Praise sendpatch.pl) Says So". There might be some reason to split the asm/uaccess.h -> linux/uaccess.h replacement into a separate commit, but the rest of that? Come on...

Trivial whitespace, etc. changes like that should be clearly marked as such and not split beyond reasonable...