runqueue: Fix handling of zero priority task

PATCH New Richard Purdie 1 participant 1 message Apr 13, 2014

Share & tools

Richard Purdie

author

2014-04-13 10:44 UTC #0 lore raw

PATCH 1/1 runqueue: Fix handling of zero priority task

The zero priority task should be run first but was being confused with the None value the priority field defaulted to. Check for None explicitly to avoid this error.

In the real world this doesn't change much but it confused the debug output from the schedulers.

Signed-off-by Richard Purdie <[email protected]>

---

bitbake/lib/bb/runqueue.py +1 -1

index 6372b65..274ccf2 100644
@@ -139,7 +139,7 @@ class RunQueueScheduler(object):
         bestprio = None
         for taskid in self.buildable:
             prio = self.rev_prio_map[taskid]
-            if not bestprio or bestprio > prio:
+            if bestprio is None or bestprio > prio:
                 stamp = self.stamps[taskid]
                 if stamp in self.rq.build_stamps.itervalues():
                     continue