Skip to contentSkip to conversation

staging: wlan-ng: Fix sparse warnings

PATCH In review [email protected] 2 participants 2 messages Apr 13, 2014 – May 15, 2014 Staging

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 staging: wlan-ng: Fix sparse warnings

From: Sarath Lakshman <[email protected]>

Fixed missed declarations for few non-static functions.

Signed-off-by Sarath Lakshman <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c   | 1 +
 drivers/staging/wlan-ng/prism2mgmt.h | 6 ++++++
 2 files changed, 7 insertions(+)
drivers/staging/wlan-ng/cfg80211.c +1 -0
index f76f95c..662581c 100644
@@ -1,4 +1,5 @@
 /* cfg80211 Interface for prism2_usb module */
+#include "prism2mgmt.h"
 
 
 /* Prism2 channel/frequency/bitrate declarations */
drivers/staging/wlan-ng/prism2mgmt.h +6 -0
index 190d390..ad049ad 100644
@@ -60,6 +60,8 @@
 #ifndef _PRISM2MGMT_H
 #define _PRISM2MGMT_H
 
+#include "hfa384x.h"
+
 extern int prism2_reset_holdtime;
 extern int prism2_reset_settletime;
 

@@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data);
 void prism2sta_commsqual_defer(struct work_struct *data);
 void prism2sta_commsqual_timer(unsigned long data);
 
+void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
+void prism2_disconnected(wlandevice_t *wlandev);
+void prism2_roamed(wlandevice_t *wlandev);
+
 #endif
Signature · 1 line
1.8.3.2
maintainer
#1 lore raw
Quoted 1 line · On Sun, Apr 13, 2014 at 10:09:49PM +0530, [email protected] wrote:

From: Sarath Lakshman <[email protected]>

This doesn't match your From: line, why?

Quoted 33 lines

Fixed missed declarations for few non-static functions.

Signed-off-by Sarath Lakshman <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c   | 1 +
 drivers/staging/wlan-ng/prism2mgmt.h | 6 ++++++
 2 files changed, 7 insertions(+)
drivers/staging/wlan-ng/cfg80211.c +1 -0
index f76f95c..662581c 100644
@@ -1,4 +1,5 @@
 /* cfg80211 Interface for prism2_usb module */
+#include "prism2mgmt.h"
 
 
 /* Prism2 channel/frequency/bitrate declarations */
drivers/staging/wlan-ng/prism2mgmt.h +2 -0
index 190d390..ad049ad 100644
@@ -60,6 +60,8 @@
 #ifndef _PRISM2MGMT_H
 #define _PRISM2MGMT_H
 
+#include "hfa384x.h"
+
 extern int prism2_reset_holdtime;
 extern int prism2_reset_settletime;

drivers/staging/wlan-ng/prism2mgmt.h void prism2sta_processing_defer(struct work_struct *data); · line 116

Quoted 6 lines
drivers/staging/wlan-ng/prism2mgmt.h +3 -0
@@ -109,4 +111,8 @@ void prism2sta_processing_defer(struct work_struct *data);
 void prism2sta_commsqual_defer(struct work_struct *data);
 void prism2sta_commsqual_timer(unsigned long data);
 
+void prism2_connect_result(wlandevice_t *wlandev, u8 failed);
+void prism2_disconnected(wlandevice_t *wlandev);
+void prism2_roamed(wlandevice_t *wlandev);

What about the existing declarations of these functions? Shouldn't they be removed?

thanks,

greg k-h