Skip to contentSkip to conversation

weston: Add weston.ini

PATCH In review Sujith H 2 participants 2 messages Apr 15, 2014

lore
Share & tools
lore

Sujith H

author
#0 lore raw

PATCH 1/1 weston: Add weston.ini

From: Sujith H <[email protected]>

Adding weston.ini to $HOME/.config. With this change user can login to $HOME and launch weston with ivi-shell.

---
 recipes-graphics/wayland/weston_1.4.0.bbappend | 11 +++++++++++
 1 file changed, 11 insertions(+)
recipes-graphics/wayland/weston_1.4.0.bbappend +11 -0
index 7a8ba6f..fb48de1 100644
@@ -12,3 +12,14 @@ PR = "r1"
 
 FILES_${PN} += "${libdir}/weston/*"
 FILES_${PN}-dbg += "${libdir}/weston/.debug/*"
+
+do_install_append() {
+   install -d ${D}/home/root/.config
+   install -m 0644 ${S}/ivi-shell/weston.ini.in ${D}/home/root/.config/weston.ini
+   sed -i -e  's/hmi-controller.so/hmi-controller.so,ivi-controller.so/' ${D}/home/root/.config/weston.ini
+   sed -i -e 's|\@libexecdir\@|${libexecdir}|' ${D}/home/root/.config/weston.ini
+   sed -i -e 's|\@abs_top_builddir\@\/data|${datadir}\/weston|' ${D}/home/root/.config/weston.ini
+   sed -i -e 's|\@abs_top_builddir\@\/clients|${bindir}|' ${D}/home/root/.config/weston.ini
+}
+
+FILES_${PN} += "/home/root/.config"
Signature · 1 line
1.8.4
#1 lore raw
Quoted 7 lines · Sujith H

From: Sujith H <[email protected]>

Adding weston.ini to $HOME/.config. With this change user can login to $HOME and launch weston with ivi-shell.

1) the package manager shouldn't install user files, unless absolutely necessary, and if you're going to do something like that, you should at least split it out into a separate package, IMO
2) you hardcode /home/root rather than using the variable for root's home directory (see bitbake.conf)
3) you don't actually mention what layer this patch is destined for. I'm guessing meta-yocto?

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics