Skip to contentSkip to conversation

staging: dgrp: Fixed coding style

PATCH In review Thomas Tanaka 3 participants 3 messages Apr 16, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgrp: Fixed coding style

Fixed line width > 80

---
 drivers/staging/dgrp/dgrp_sysfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/dgrp/dgrp_sysfs.c +2 -2
index 2f9345f..93803e0c 100644
@@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
 	ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
 		&dgrp_global_settings_attribute_group);
 	if (ret) {
-		pr_alert("%s: failed to create sysfs global settings device attributes.\n",
-			__func__);
+		pr_alert("%s: failed to create sysfs global settings device
+			 attributes.\n", __func__);
 		goto err_dev1;
 	}
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 12 lines · Thomas Tanaka

Fixed line width > 80

---
 drivers/staging/dgrp/dgrp_sysfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/dgrp/dgrp_sysfs.c +0 -0
index 2f9345f..93803e0c 100644

drivers/staging/dgrp/dgrp_sysfs.c int dgrp_create_class_sysfs_files(void) · line 112

Quoted 7 lines
drivers/staging/dgrp/dgrp_sysfs.c +2 -2
@@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
 	ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
 		&dgrp_global_settings_attribute_group);
 	if (ret) {
-		pr_alert("%s: failed to create sysfs global settings device attributes.\n",
-			__func__);
+		pr_alert("%s: failed to create sysfs global settings device
+			 attributes.\n", __func__);

The original was fine. It doesn't cause a checkpatch.pl warning. The new one is buggy and won't print the correct text.

regards,
dan carpenter

#2 lore raw
Quoted 8 lines · Dan Carpenter
Quoted 7 lines · Thomas Tanaka

Fixed line width > 80

---
 drivers/staging/dgrp/dgrp_sysfs.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 15 lines

drivers/staging/dgrp/dgrp_sysfs.c int dgrp_create_class_sysfs_files(void) · line 112

Quoted 12 lines
drivers/staging/dgrp/dgrp_sysfs.c +2 -2
index 2f9345f..93803e0c 100644
@@ -108,8 +108,8 @@ int dgrp_create_class_sysfs_files(void)
 	ret = sysfs_create_group(&dgrp_class_global_settings_dev->kobj,
 		&dgrp_global_settings_attribute_group);
 	if (ret) {
-		pr_alert("%s: failed to create sysfs global settings device attributes.\n",
-			__func__);
+		pr_alert("%s: failed to create sysfs global settings device
+			 attributes.\n", __func__);

The original was fine. It doesn't cause a checkpatch.pl warning. The new one is buggy and won't print the correct text.

Yes, right. In this case, it prints some tabs between 'device' and 'attributes.' So, this patch should be NAKed.

Best regards,
Jingoo Han

Quoted 3 lines

regards,
dan carpenter