Skip to contentSkip to conversation

perf, x86: Don't mark DataLA addresses as store

PATCH NAK Andi Kleen 2 participants 3 messages Apr 17, 2014 – Apr 18, 2014

Subsystems (2)
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf, x86: Don't mark DataLA addresses as store

From: Andi Kleen <[email protected]>

Haswell supports reporting the data address for a range of events, including UOPS_RETIRED.ALL and some load events. Currently these addresses were always marked as stores, which is wrong, as they could be loads too. Change it to NA instead.

---
 arch/x86/kernel/cpu/perf_event_intel_ds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/perf_event_intel_ds.c +1 -1
index ae96cfa..7e9546a 100644
@@ -113,7 +113,7 @@ static u64 precise_store_data_hsw(u64 status)
 	union perf_mem_data_src dse;
 
 	dse.val = 0;
-	dse.mem_op = PERF_MEM_OP_STORE;
+	dse.mem_op = PERF_MEM_OP_NA;
 	dse.mem_lvl = PERF_MEM_LVL_NA;
 	if (status & 1)
 		dse.mem_lvl = PERF_MEM_LVL_L1;
Signature · 1 line
1.8.5.3
#1 lore raw
Quoted 18 lines · Andi Kleen

From: Andi Kleen <[email protected]>

Haswell supports reporting the data address for a range of events, including UOPS_RETIRED.ALL and some load events. Currently these addresses were always marked as stores, which is wrong, as they could be loads too. Change it to NA instead.

---
 arch/x86/kernel/cpu/perf_event_intel_ds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/cpu/perf_event_intel_ds.c +0 -0
index ae96cfa..7e9546a 100644

arch/x86/kernel/cpu/perf_event_intel_ds.c static u64 precise_store_data_hsw(u64 status) · line 119

Quoted 8 lines
arch/x86/kernel/cpu/perf_event_intel_ds.c +1 -1
@@ -113,7 +113,7 @@ static u64 precise_store_data_hsw(u64 status)
 	union perf_mem_data_src dse;
 
 	dse.val = 0;
-	dse.mem_op = PERF_MEM_OP_STORE;
+	dse.mem_op = PERF_MEM_OP_NA;
 	dse.mem_lvl = PERF_MEM_LVL_NA;
 	if (status & 1)
 		dse.mem_lvl = PERF_MEM_LVL_L1;

NAK, this changelog is still deficient for the same reason it was deficient a month ago.

Thanks,

Ingo

author
#2 lore raw
Quoted 2 lines

NAK, this changelog is still deficient for the same reason it was deficient a month ago.

The post last time didn't get any comments on this patch at all.

I don't see anything wrong with the changelog. It explains the problem completely and succiently. If you want improvements please be more specific.

-Andi