perf test x86: Fit memory leak in sample_ustack()
PATCH 1/1 perf test x86: Fit memory leak in sample_ustack()
buf is not freed, when kernel failed to get stack map and return.
Signed-off-by Masanari Iida <[email protected]>
--- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/arch/x86/tests/dwarf-unwind.c +1 -0
@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample, map =map_groups__find (&thread->mg,MAP__FUNCTION , (u64 ) sp);if (!map) {pr_debug ("failed to get stack map\n" ); +kfree (buf);return -1 ; }
Signature · 1 line
1.9.2.468.g3f0c02a
Quoted 4 lines · Masanari Iida
buf is not freed, when kernel failed to get stack map and return.
Signed-off-by Masanari Iida <[email protected]>
Acked-by Jiri Olsa <[email protected]>
thanks,
jirka
Quoted 19 lines
--- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + 1 file changed, 1 insertion(+)tools/perf/arch/x86/tests/dwarf-unwind.c +1
-0@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample, map =map_groups__find (&thread->mg,MAP__FUNCTION , (u64 ) sp);if (!map) {pr_debug ("failed to get stack map\n" ); +kfree (buf);return -1 ; }Signature · 1 line
1.9.2.468.g3f0c02a
Quoted 15 lines · Jiri Olsa
Quoted 4 lines · Masanari Iida
buf is not freed, when kernel failed to get stack map and return.
Signed-off-by Masanari Iida <[email protected]>Acked-by Jiri Olsa <[email protected]>thanks,
jirkaQuoted 4 lines
--- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + 1 file changed, 1 insertion(+)
Quoted 9 lines
tools/perf/arch/x86/tests/dwarf-unwind.c static int sample_ustack(struct perf_sample *sample, · line 29
Quoted 9 lines
tools/perf/arch/x86/tests/dwarf-unwind.c +1
-0@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample, map =map_groups__find (&thread->mg,MAP__FUNCTION , (u64 ) sp);if (!map) {pr_debug ("failed to get stack map\n" ); +kfree (buf);
and changing this to free(buf) ;-)
jirka
Quoted 6 lines
Quoted 6 lines
tools/perf/arch/x86/tests/dwarf-unwind.c +0
-0return -1 ; }Signature · 1 line
1.9.2.468.g3f0c02a
buf is not freed, when program failed to get stack map
Signed-off-by Masanari Iida <[email protected]>
Acked-by Jiri Olsa <[email protected]>
--- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/arch/x86/tests/dwarf-unwind.c +1 -0
@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample, map =map_groups__find (&thread->mg,MAP__FUNCTION , (u64 ) sp);if (!map) {pr_debug ("failed to get stack map\n" ); +free (buf);return -1 ; }
Signature · 1 line
1.9.2.468.g3f0c02a
tip-bot for Masanari Iida
merge bot[tip:perf/urgent] perf tests x86: Fix memory leak in sample_ustack()
perf tests x86: Fix memory leak in sample_ustack()
Commit-ID: 763d7f5f2718f085bab5a9e63308349728f3ad12 Gitweb: http://git.kernel.org/tip/763d7f5f2718f085bab5a9e63308349728f3ad12 Author: Masanari Iida <[email protected]> AuthorDate: Sun, 20 Apr 2014 00:16:41 +0900 Committer: Jiri Olsa <[email protected]> CommitDate: Wed, 23 Apr 2014 13:19:01 +0200
perf tests x86: Fix memory leak in sample_ustack()
The buf is not freed, when kernel failed to get stack map and return.
Signed-off-by Masanari Iida <[email protected]>
Signed-off-by Jiri Olsa <[email protected]>
--- tools/perf/arch/x86/tests/dwarf-unwind.c | 1 + 1 file changed, 1 insertion(+)
tools/perf/arch/x86/tests/dwarf-unwind.c +1 -0
@@ -26,6 +26,7 @@ static int sample_ustack(struct perf_sample *sample, map =map_groups__find (&thread->mg,MAP__FUNCTION , (u64 ) sp);if (!map) {pr_debug ("failed to get stack map\n" ); +free (buf);return -1 ; }