Skip to contentSkip to conversation

Fixed spelling errors within comments

PATCH Applied Terence Eden 3 participants 3 messages Apr 20, 2014 – Apr 21, 2014 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed spelling errors within comments

From: Terence Eden <[email protected]>

This is my first patch submission. Please let me know if I have made a mistake anywhere.

---
 arch/arc/kernel/entry.S |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arc/kernel/entry.S +6 -6
index 819dd5f..38ef91a 100644
@@ -156,7 +156,7 @@ ARCFP_DATA int1_saved_reg
 int1_saved_reg:
 	.zero 4
 
-/* Each Interrupt level needs it's own scratch */
+/* Each Interrupt level needs its own scratch */
 #ifdef CONFIG_ARC_COMPACT_IRQ_LEVELS
 
 ARCFP_DATA int2_saved_reg
@@ -473,7 +473,7 @@ trap_with_param:
 	lr  r0, [efa]
 	mov r1, sp
 
-	; Now that we have read EFA, its safe to do "fake" rtie
+	; Now that we have read EFA, it is safe to do "fake" rtie
 	;   and get out of CPU exception mode
 	FAKE_RET_FROM_EXCPN r11
 
@@ -676,9 +676,9 @@ not_exception:
 	brne r9, event_IRQ2, 149f
 
 	;------------------------------------------------------------------
-	; if L2 IRQ interrupted a L1 ISR,  we'd disbaled preemption earlier
-	; so that sched doesnt move to new task, causing L1 to be delayed
-	; undeterministically. Now that we've achieved that, lets reset
+	; if L2 IRQ interrupted a L1 ISR,  we'd disabled preemption earlier
+	; so that sched doesn't move to new task, causing L1 to be delayed
+	; undeterministically. Now that we've achieved that, let's reset
 	; things to what they were, before returning from L2 context
 	;----------------------------------------------------------------
 
@@ -734,7 +734,7 @@ ENTRY(ret_from_fork)
 	; put last task in scheduler queue
 	bl   @schedule_tail
 
-	; If kernel thread, jump to it's entry-point
+	; If kernel thread, jump to its entry-point
 	ld   r9, [sp, PT_status32]
 	brne r9, 0, 1f
 
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Terence Eden

From: Terence Eden <[email protected]>

This is my first patch submission. Please let me know if I have made a mistake anywhere.

trivial's email address is [email protected] (cc-ed).

Quoted 27 lines
---
 arch/arc/kernel/entry.S |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
arch/arc/kernel/entry.S +2 -2
index 819dd5f..38ef91a 100644
@@ -156,7 +156,7 @@ ARCFP_DATA int1_saved_reg
 int1_saved_reg:
 	.zero 4
 
-/* Each Interrupt level needs it's own scratch */
+/* Each Interrupt level needs its own scratch */
 #ifdef CONFIG_ARC_COMPACT_IRQ_LEVELS
 
 ARCFP_DATA int2_saved_reg
@@ -473,7 +473,7 @@ trap_with_param:
 	lr  r0, [efa]
 	mov r1, sp
 
-	; Now that we have read EFA, its safe to do "fake" rtie
+	; Now that we have read EFA, it is safe to do "fake" rtie
 	;   and get out of CPU exception mode
 	FAKE_RET_FROM_EXCPN r11
 

arch/arc/kernel/entry.S not_exception: · line 679

Quoted 7 lines
arch/arc/kernel/entry.S +1 -3
@@ -676,9 +676,9 @@ not_exception:
 	brne r9, event_IRQ2, 149f
 
 	;------------------------------------------------------------------
-	; if L2 IRQ interrupted a L1 ISR,  we'd disbaled preemption earlier
-	; so that sched doesnt move to new task, causing L1 to be delayed
-	; undeterministically. Now that we've achieved that, lets reset
+	; if L2 IRQ interrupted a L1 ISR,  we'd disabled preemption earlier

I would write: an L1 ISR,

anyway:

Quoted 15 lines
arch/arc/kernel/entry.S +3 -1
+	; so that sched doesn't move to new task, causing L1 to be delayed
+	; undeterministically. Now that we've achieved that, let's reset
 	; things to what they were, before returning from L2 context
 	;----------------------------------------------------------------
 
@@ -734,7 +734,7 @@ ENTRY(ret_from_fork)
 	; put last task in scheduler queue
 	bl   @schedule_tail
 
-	; If kernel thread, jump to it's entry-point
+	; If kernel thread, jump to its entry-point
 	ld   r9, [sp, PT_status32]
 	brne r9, 0, 1f
 
Signature · 1 line
~Randy
Applied
#2 lore raw

Hi Terence,

Thanks for the fixes.

Quoted 10 lines · Randy Dunlap
Quoted 5 lines · Terence Eden
Quoted 4 lines

From: Terence Eden <[email protected]>

This is my first patch submission. Please let me know if I have made a mistake anywhere.

...

I would write: an L1 ISR,

anyway:

Applied to ARC for-next with Randy's ACK.

-Vineet