Skip to contentSkip to conversation

misc: genwqe: Fix format string mismatch in card_debugfs.c

PATCH In review Masanari Iida 2 participants 2 messages Apr 24, 2014 – May 5, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: genwqe: Fix format string mismatch in card_debugfs.c

Fix two format string mismatch in genwqe_init_debugfs()

---
 drivers/misc/genwqe/card_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/genwqe/card_debugfs.c +2 -2
index 50d2096..0a33ade 100644
@@ -348,7 +348,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
 	char name[64];
 	unsigned int i;
 
-	sprintf(card_name, "%s%u_card", GENWQE_DEVNAME, cd->card_idx);
+	sprintf(card_name, "%s%d_card", GENWQE_DEVNAME, cd->card_idx);
 
 	root = debugfs_create_dir(card_name, cd->debugfs_genwqe);
 	if (!root) {
@@ -454,7 +454,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
 	}
 
 	for (i = 0; i <  GENWQE_MAX_VFS; i++) {
-		sprintf(name, "vf%d_jobtimeout_msec", i);
+		sprintf(name, "vf%u_jobtimeout_msec", i);
 
 		file = debugfs_create_u32(name, 0666, root,
 					  &cd->vf_jobtimeout_msec[i]);
Signature · 1 line
2.0.0.rc0.26.g779792a
Acked-by on v1 1/1
#1 lore raw

Am Donnerstag, den 24.04.2014, 12:25 +0900 schrieb Masanari Iida:

Quoted 21 lines

Fix two format string mismatch in genwqe_init_debugfs()

---
 drivers/misc/genwqe/card_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/genwqe/card_debugfs.c +1 -1
index 50d2096..0a33ade 100644
@@ -348,7 +348,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
 	char name[64];
 	unsigned int i;
 
-	sprintf(card_name, "%s%u_card", GENWQE_DEVNAME, cd->card_idx);
+	sprintf(card_name, "%s%d_card", GENWQE_DEVNAME, cd->card_idx);
 
 	root = debugfs_create_dir(card_name, cd->debugfs_genwqe);
 	if (!root) {

drivers/misc/genwqe/card_debugfs.c int genwqe_init_debugfs(struct genwqe_dev *cd) · line 460

Quoted 8 lines
drivers/misc/genwqe/card_debugfs.c +1 -1
@@ -454,7 +454,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
 	}
 
 	for (i = 0; i <  GENWQE_MAX_VFS; i++) {
-		sprintf(name, "vf%d_jobtimeout_msec", i);
+		sprintf(name, "vf%u_jobtimeout_msec", i);
 
 		file = debugfs_create_u32(name, 0666, root,
 					  &cd->vf_jobtimeout_msec[i]);

Thanks for contributing the fix for our driver. I do not see that this would ever be able to cause a problem. Or do I oversee something? Regardless of that it appears to looks nicer.