Skip to contentSkip to conversation

net/designware: call phy_connect_dev() to properly setup phylib device

PATCH Superseded Ian Campbell 2 participants 8 messages Apr 28, 2014 – May 21, 2014 Network drivers

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/designware: call phy_connect_dev() to properly setup phylib device

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Cc Alexey Brodkin <[email protected]>
---
 drivers/net/designware.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/designware.c +2 -0
index c9afe16..b8a7631 100644
@@ -390,6 +390,8 @@ static int dw_phy_init(struct eth_device *dev)
 	if (!phydev)
 		return -1;
 
+	phy_connect_dev(phydev, dev);
+
 	phydev->supported &= PHY_GBIT_FEATURES;
 	phydev->advertising = phydev->supported;
 
Signature · 1 line
1.9.0
#1 lore raw
Quoted 8 lines · Ian Campbell

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Cc Alexey Brodkin <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140512/1e0ae36c/attachment.pgp>
#2 lore raw
Quoted 8 lines · Tom Rini
Quoted 6 lines · Ian Campbell

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Quoted 4 lines
Quoted 2 lines
Cc Alexey Brodkin <[email protected]>

Applied to u-boot/master, thanks!

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

Ian.

#3 lore raw
Quoted 12 lines · Ian Campbell
Quoted 11 lines · Tom Rini
Quoted 8 lines · Ian Campbell

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Cc Alexey Brodkin <[email protected]>
Quoted 6 lines
Quoted 1 line

Applied to u-boot/master, thanks!

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

For the moment I've tossed all of the rest of them over to Albert to grab along with the sunxi stuff. Albert, if you're uncomfortable there I can pick them up instead, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140513/b8f0befe/attachment.pgp>
#4 lore raw
Quoted 15 lines · Tom Rini
Quoted 14 lines · Ian Campbell
Quoted 12 lines · Tom Rini
Quoted 8 lines · Ian Campbell

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Cc Alexey Brodkin <[email protected]>

Applied to u-boot/master, thanks!

Quoted 7 lines
Quoted 4 lines

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

For the moment I've tossed all of the rest of them over to Albert to grab along with the sunxi stuff.

OK, thanks. Does that mean they should be delegated to him in patchwork (because they still say trini)?

Quoted 2 lines

Albert, if you're uncomfortable there
I can pick them up instead, thanks!

Cheers,
Ian.

#5 lore raw
Quoted 21 lines · Ian Campbell
Quoted 20 lines · Tom Rini
Quoted 18 lines · Ian Campbell
Quoted 8 lines · Tom Rini
Quoted 6 lines · Ian Campbell

This sets up the linkage from the phydev back to the ethernet device. This symptom of not doing this which I noticed was:
<NULL> Waiting for PHY auto negotiation to complete....
rather than:
dwmac.1c50000 Waiting for PHY auto negotiation to complete....

Quoted 4 lines
Quoted 2 lines
Cc Alexey Brodkin <[email protected]>

Applied to u-boot/master, thanks!

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

Quoted 5 lines
Quoted 2 lines

For the moment I've tossed all of the rest of them over to Albert to grab along with the sunxi stuff.

OK, thanks. Does that mean they should be delegated to him in patchwork (because they still say trini)?

I think I forgot to update them, oops. I checked with Albert on IRC just now and he's fine with it and will grab them tomorrow.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140514/c4e06c50/attachment.pgp>
#6 lore raw
Quoted 8 lines · Tom Rini
Quoted 7 lines · Ian Campbell
Quoted 6 lines · Tom Rini
Quoted 4 lines · Ian Campbell

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

For the moment I've tossed all of the rest of them over to Albert to grab along with the sunxi stuff.

OK, thanks. Does that mean they should be delegated to him in patchwork (because they still say trini)?

I think I forgot to update them, oops. I checked with Albert on IRC just now and he's fine with it and will grab them tomorrow.

Hi,

I was just wondering what the status of these two series was.

Thanks,
Ian.

#7 lore raw
Quoted 15 lines · Ian Campbell
Quoted 14 lines · Tom Rini
Quoted 12 lines · Ian Campbell
Quoted 8 lines · Tom Rini
Quoted 4 lines · Ian Campbell

Thanks, have you also seen "[PATCH v3 0/5] net/designware: fixes for data cache, phylib and burst size" which included this and some other (far more critical, since designware is currently unusable on ARM) fixes?

For the moment I've tossed all of the rest of them over to Albert to grab along with the sunxi stuff.

OK, thanks. Does that mean they should be delegated to him in patchwork (because they still say trini)?

Quoted 6 lines
Quoted 2 lines

I think I forgot to update them, oops. I checked with Albert on IRC just now and he's fine with it and will grab them tomorrow.

Hi,

I was just wondering what the status of these two series was.

You had posted v3.1 of one of the patches or so when I had poked Albert on IRC about grabbing it and he said he hadn't seen 3.1 just yet. Albert? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140521/a3b9f906/attachment.pgp>