Skip to contentSkip to conversation

tools/perf: remove yet another strtoull()

PATCH New Andy Shevchenko 1 participant 1 message Apr 29, 2014 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/perf: remove yet another strtoull()

Cc Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/util.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)
tools/perf/util/util.c +1 -21
index 9f66549..77360e1 100644
@@ -203,17 +203,6 @@ size_t hex_width(u64 v)
 	return n;
 }
 
-static int hex(char ch)
-{
-	if ((ch >= '0') && (ch <= '9'))
-		return ch - '0';
-	if ((ch >= 'a') && (ch <= 'f'))
-		return ch - 'a' + 10;
-	if ((ch >= 'A') && (ch <= 'F'))
-		return ch - 'A' + 10;
-	return -1;
-}
-
 /*
  * While we find nice hex chars, build a long_val.
  * Return number of chars processed.
@@ -221,17 +210,8 @@ static int hex(char ch)
 int hex2u64(const char *ptr, u64 *long_val)
 {
 	const char *p = ptr;
-	*long_val = 0;
-
-	while (*p) {
-		const int hex_val = hex(*p);
 
-		if (hex_val < 0)
-			break;
-
-		*long_val = (*long_val << 4) | hex_val;
-		p++;
-	}
+	*long_val = strtoull(ptr, &p, 16);
 
 	return p - ptr;
 }
Signature · 1 line
1.9.2