arcmsr: Revise interrupt service routine relate function
PATCH 1/11 arcmsr: Revise interrupt service routine relate function
From: Ching<[email protected]>
Rewrite interrupt service routine relate function to fix command timeout on controller very heavy loading.
---
drivers/scsi/arcmsr/arcmsr.h +1 -1
@@ -51,7 +51,7 @@ struct device_attribute;#else #define ARCMSR_MAX_FREECCB_NUM 320#endif -#define ARCMSR_DRIVER_VERSION "Driver Version 1.20.00.15 2010/08/05" +#define ARCMSR_DRIVER_VERSION "v1.30.00.04-20140428"#define ARCMSR_SCSI_INITIATOR_ID 255#define ARCMSR_MAX_XFER_SECTORS 512#define ARCMSR_MAX_XFER_SECTORS_B 4096
drivers/scsi/arcmsr/arcmsr_hba.c +97 -101
241 lines not on this page · raw message
Quoted 4 lines · ching
From: Ching<[email protected]>
Rewrite interrupt service routine relate function to fix command timeout on controller very heavy loading.
OK, so I think you've confused us a bit. This looks to be an update of your previous v1.4 patch set, yet it's now called v1.0?
Could you please include a cover letter as patch 0/x like you see everyone else doing on the list? In this cover letter can you tell us what the disposition of the previous feedback is and what other changes have you done? You didn't reply to any of the comments, have have you fixed them? It's very dispiriting to review 11 patches, give feedback and not hear anything ... and then have to review an even longer set of patches just to see if anything was done about your previous comments.
The less interactive you are with reviews, the less chance there is that people will review updates ... without external reviewers, you go on a very long backlog of things I have to review before the patches get in.
James
Hi James,
Indeed, it makes you confusion that I mistake typing the subject. It should be [PATCH v1.0 1/16] , but not [PATCH v1.0 1/11].
Why I use v1.0 other than v1.4? Changing from 11 patches to 16 patches. Because I spend a long time to simplify each patch, so patch number is increase. It is easier to review.
I am so sorry for late to response that make you are inconvenient.
Quoted 1 line
From now on, I will response quickly.
Thanks for your advice.
2014-05-01 0:56 GMT+08:00 James Bottomley <[email protected]>:
Quoted 23 lines · ching
Quoted 4 lines
From: Ching<[email protected]>
Rewrite interrupt service routine relate function to fix command timeout on controller very heavy loading.
OK, so I think you've confused us a bit. This looks to be an update of your previous v1.4 patch set, yet it's now called v1.0?
Could you please include a cover letter as patch 0/x like you see everyone else doing on the list? In this cover letter can you tell us what the disposition of the previous feedback is and what other changes have you done? You didn't reply to any of the comments, have have you fixed them? It's very dispiriting to review 11 patches, give feedback and not hear anything ... and then have to review an even longer set of patches just to see if anything was done about your previous comments.
The less interactive you are with reviews, the less chance there is that people will review updates ... without external reviewers, you go on a very long backlog of things I have to review before the patches get in.
James