sparc32: fix sparse warnings in sys_sparc_32.c
PATCH 6/12 sparc32: fix sparse warnings in sys_sparc_32.c
Fix following warnings:
sys_sparc_32.c:32:26: warning: symbol 'sys_getpagesize' was not declared. Should it be static? sys_sparc_32.c:71:16: warning: symbol 'sparc_pipe' was not declared. Should it be static? sys_sparc_32.c:96:26: warning: symbol 'sys_mmap2' was not declared. Should it be static? sys_sparc_32.c:106:26: warning: symbol 'sys_mmap' was not declared. Should it be static? sys_sparc_32.c:114:6: warning: symbol 'sparc_remap_file_pages' was not declared. Should it be static? sys_sparc_32.c:127:1: warning: symbol 'c_sys_nis_syscall' was not declared. Should it be static? sys_sparc_32.c:144:1: warning: symbol 'sparc_breakpoint' was not declared. Should it be static? sys_sparc_32.c:200:16: warning: symbol 'sys_getdomainname' was not declared. Should it be static?
Adapt systbls.h for use by both sparc32 + sparc64. In the process modify the return type of a few functions:
From unsigned long to long:sys_mmap2()sys_mmap()
From int to long:sparc_pipe()sys_getdomainname()
The changed return type was done to align with sparc64, and to actually match the type that was returned.
As we cross a syscall boundary the user will not see this change.
--- arch/sparc/kernel/sys_sparc_32.c | 10 +++--- arch/sparc/kernel/systbls.h | 71 +++++++++++++++++++++++----------------- 2 files changed, 47 insertions(+), 34 deletions(-)
arch/sparc/kernel/sys_sparc_32.c +6 -4
@@ -24,6 +24,8 @@#include <asm/uaccess.h> #include <asm/unistd.h> +#include "systbls.h" +/* #define DEBUG_UNIMP_SYSCALL */ /* XXX Make this per-binary type, this way we can detect the type of
@@ -68,7 +70,7 @@ unsigned long arch_get_unmapped_area(struct file *filp, unsigned long addr, unsi* sys_pipe() is the normal C calling standard for creating * a pipe. It's not the way unix traditionally does this, though. */ -asmlinkage int sparc_pipe(struct pt_regs *regs) +asmlinkage long sparc_pipe (struct pt_regs *regs) {int fd[2 ];int error;
@@ -93,7 +95,7 @@ int sparc_mmap_check(unsigned long addr, unsigned long len)/* Linux version of mmap */ -asmlinkage unsigned long sys_mmap2 (unsigned long addr,unsigned long len, +asmlinkage long sys_mmap2 (unsigned long addr,unsigned long len,unsigned long prot,unsigned long flags,unsigned long fd,unsigned long pgoff) {
@@ -103,7 +105,7 @@ asmlinkage unsigned long sys_mmap2(unsigned long addr, unsigned long len, pgoff >> (PAGE_SHIFT - 12)); } -asmlinkage unsigned long sys_mmap (unsigned long addr,unsigned long len, +asmlinkage long sys_mmap (unsigned long addr,unsigned long len,unsigned long prot,unsigned long flags,unsigned long fd,unsigned long off) {
@@ -197,7 +199,7 @@ SYSCALL_DEFINE5(rt_sigaction, int, sig,return ret; } -asmlinkage int sys_getdomainname(char __user *name, int len) +asmlinkage long sys_getdomainname (char __user *name,int len) {int nlen, err;
arch/sparc/kernel/systbls.h +41 -30
77 lines not on this page · raw message
Signature · 1 line
1.9.0