sparc: fix sparse warning in math_{32,64}

PATCH In review Sam Ravnborg 1 participant 1 message May 2, 2014 SPARC + UltraSPARC (sparc/sparc64)

lore

Share & tools

lore

Sam Ravnborg

author

2014-05-02 15:03 UTC #0 lore raw

PATCH 9/12 sparc: fix sparse warning in math_{32,64}

Fix following sparse warning:
math_{32,64}.c: warning: symbol 'do_mathemu' was not declared. Should it be static?

Add prototype in processor_{32,64} and drop extern in traps_{32,64}.c

Signed-off-by Sam Ravnborg <[email protected]>

---
 arch/sparc/include/asm/processor_32.h | 1 +
 arch/sparc/include/asm/processor_64.h | 2 ++
 arch/sparc/kernel/traps_32.c          | 2 --
 arch/sparc/kernel/traps_64.c          | 2 --
 4 files changed, 3 insertions(+), 4 deletions(-)

arch/sparc/include/asm/processor_32.h +1 -0

index 2c7baa4..2bc9818 100644
@@ -116,6 +116,7 @@ extern unsigned long get_wchan(struct task_struct *);
 #ifdef __KERNEL__
 
 extern struct task_struct *last_task_used_math;
+int do_mathemu(struct pt_regs *regs, struct task_struct *fpt);
 
 #define cpu_relax()	barrier()
 extern void (*sparc_idle)(void);

arch/sparc/include/asm/processor_64.h +2 -0

index 4c3f7f0..27ff7ae 100644
@@ -253,6 +253,8 @@ static inline void prefetchw(const void *x)
 
 #define HAVE_ARCH_PICK_MMAP_LAYOUT
 
+int do_mathemu(struct pt_regs *regs, struct fpustate *f, bool illegal_insn_trap);
+
 #endif /* !(__ASSEMBLY__) */
 
 #endif /* !(__ASM_SPARC64_PROCESSOR_H) */

arch/sparc/kernel/traps_32.c +0 -2

index a655e5b..6fd386c 100644
@@ -219,8 +219,6 @@ static unsigned long fake_fsr;
 static unsigned long fake_queue[32] __attribute__ ((aligned (8)));
 static unsigned long fake_depth;
 
-extern int do_mathemu(struct pt_regs *, struct task_struct *);
-
 void do_fpe_trap(struct pt_regs *regs, unsigned long pc, unsigned long npc,
 		 unsigned long psr)
 {

arch/sparc/kernel/traps_64.c +0 -2

index 4ced92f..4d7e12d 100644
@@ -2209,8 +2209,6 @@ out:
 	exception_exit(prev_state);
 }
 
-extern int do_mathemu(struct pt_regs *, struct fpustate *, bool);
-
 void do_fpother(struct pt_regs *regs)
 {
 	enum ctx_state prev_state = exception_enter();

Signature · 1 line

1.9.0