Skip to contentSkip to conversation

xfstests: use killall -9 and wait in _cleanup() in xfs/013

PATCH New Brian Foster 1 participant 1 message May 13, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests: use killall -9 and wait in _cleanup() in xfs/013

Kill any lingering fsstress processes and wait properly should we abort the test. This prevents the workload from inadvertently affecting subsequent tests.

---

Dave,

Sorry, this probably should have been posted sooner. I was half expecting to have more changes to the test. Looks like you fixed up the groups already (thanks), so here's a small one to fix up the exit path... Obviously it's not the end of the world if this waits for the next natural xfstests update. :)

Brian

 tests/xfs/013 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/xfs/013 +2 -1
index 049f0dc..e95d027 100755
@@ -40,7 +40,8 @@ status=1	# failure is the default!
 
 _cleanup()
 {
-	killall fsstress 2>/dev/null
+	killall -9 fsstress 2>/dev/null
+	wait
 	cd /
 	umount $SCRATCH_MNT 2>/dev/null
 	rm -f $tmp.*
Signature · 6 lines
1.8.3.1

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs