Skip to contentSkip to conversation

dgap: fix sparse warnings

PATCH In review Jinqiang Zeng 2 participants 2 messages May 14, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dgap: fix sparse warnings

fix the sparse warnings
drivers/staging/dgap/dgap.c:689:28: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/dgap/dgap.c:689:28: expected void volatile [noderef] <asn:2>*addr
drivers/staging/dgap/dgap.c:689:28: got unsigned char [usertype] *re_map_port
drivers/staging/dgap/dgap.c:695:28: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/dgap/dgap.c:695:28: expected void volatile [noderef] <asn:2>*addr
drivers/staging/dgap/dgap.c:695:28: got unsigned char [usertype] *re_map_membase

---
 drivers/staging/dgap/dgap.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/dgap/dgap.h +2 -2
index 6b8f5f8..bceff7d 100644
@@ -578,8 +578,8 @@ struct board_t {
 	ulong		membase;	/* Start of base memory of the card */
 	ulong		membase_end;	/* End of base memory of the card */
 
-	uchar 		*re_map_port;	/* Remapped io port of the card */
-	uchar		*re_map_membase;/* Remapped memory of the card */
+	uchar __iomem   *re_map_port;	/* Remapped io port of the card */
+	uchar __iomem	*re_map_membase;/* Remapped memory of the card */
 
 	uchar		runwait;	/* # Processes waiting for FEP  */
 	uchar		inhibit_poller; /* Tells  the poller to leave us alone */
Signature · 1 line
1.7.7.6
#1 lore raw

You should be working against linux-next. Also Mark Hounschell has sent a fix for this already but it hasn't been applied yet. The subject should have "Staging" in it.

[PATCH] Staging: dgap: addd __iomem annotations.

Otherwise looks ok.

regards,
dan carpenter