Skip to contentSkip to conversation

drm: Missed clflushopt in drm_clflush_virt_range

PATCH In review Ross Zwisler 3 participants 4 messages May 14, 2014 – May 15, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Missed clflushopt in drm_clflush_virt_range

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush in drm_clflush_virt_range. There were two calls to clflush in this function, but only one was changed to clflushopt. This patch changes the other clflush call to clflushopt.

Cc David Airlie <[email protected]>
Cc H Peter Anvin <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
---
 drivers/gpu/drm/drm_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_cache.c +1 -1
index 534cb89..041b73b 100644
@@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
 		char *end = addr + length;
 		mb();
 		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
-			clflush(addr);
+			clflushopt(addr);
 		clflushopt(end - 1);
 		mb();
 		return;
Signature · 1 line
1.9.0
#1 lore raw
Quoted 9 lines · Ross Zwisler

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush in drm_clflush_virt_range. There were two calls to clflush in this function, but only one was changed to clflushopt. This patch changes the other clflush call to clflushopt.

Quoted 8 lines
Cc David Airlie <[email protected]>
Cc H Peter Anvin <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>

Picked to my topic/core-stuff drm branch so it doesn't get lost. -Daniel

Quoted 25 lines
---
 drivers/gpu/drm/drm_cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_cache.c +1 -1
index 534cb89..041b73b 100644
@@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length)
 		char *end = addr + length;
 		mb();
 		for (; addr < end; addr += boot_cpu_data.x86_clflush_size)
-			clflush(addr);
+			clflushopt(addr);
 		clflushopt(end - 1);
 		mb();
 		return;
Signature · 6 lines
1.9.0

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 13 lines · Daniel Vetter
Quoted 12 lines · Ross Zwisler

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush in drm_clflush_virt_range. There were two calls to clflush in this function, but only one was changed to clflushopt. This patch changes the other clflush call to clflushopt.

Quoted 9 lines
Quoted 5 lines
Cc David Airlie <[email protected]>
Cc H Peter Anvin <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>

Picked to my topic/core-stuff drm branch so it doesn't get lost. -Daniel

Does this mean you're picking this up, or do you want me to put it into -tip?

-hpa

#3 lore raw
Quoted 20 lines · H. Peter Anvin
Quoted 19 lines · Daniel Vetter
Quoted 17 lines · Ross Zwisler

With this commit:

2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range

If clflushopt is available on the system, we use it instead of clflush in drm_clflush_virt_range. There were two calls to clflush in this function, but only one was changed to clflushopt. This patch changes the other clflush call to clflushopt.

Cc David Airlie <[email protected]>
Cc H Peter Anvin <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Thomas Gleixner <[email protected]>
Quoted 5 lines
Quoted 3 lines

Picked to my topic/core-stuff drm branch so it doesn't get lost. -Daniel

Does this mean you're picking this up, or do you want me to put it into

I'll forward it eventually to Dave for 3.16. But if someone else steals it beforehand I don't mind ;-)
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch