Skip to contentSkip to conversation

cpupower: Remove redundant error check

PATCH New Peter Senna Tschudin 1 participant 1 message May 17, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 2/4 cpupower: Remove redundant error check

Remove double checks, and move the call to print_error to the first check. Replace break by return, and return 0 on success. The simplified version of the coccinelle semantic patch that fixes this issue is as follows:

// <smpl>
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// </smpl>

Untested.

---
Changes from V1:
- Replaced break with a return
- Return 0 instead of ret on success

 tools/power/cpupower/utils/cpufreq-set.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
tools/power/cpupower/utils/cpufreq-set.c +5 -6
index a416de8..f656e58 100644
@@ -320,12 +320,11 @@ int cmd_freq_set(int argc, char **argv)
 
 		printf(_("Setting cpu: %d\n"), cpu);
 		ret = do_one_cpu(cpu, &new_pol, freq, policychange);
-		if (ret)
-			break;
+		if (ret) {
+			print_error();
+			return ret;
+		}
 	}
 
-	if (ret)
-		print_error();
-
-	return ret;
+	return 0;
 }