Skip to contentSkip to conversation

ASoC: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

PATCH Applied Xiubo Li 2 participants 2 messages May 19, 2014 – Jun 1, 2014

Subsystems (2)
lore
Share & tools
lore

Xiubo Li

author
#0 lore raw

PATCH 1/1 ASoC: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

Since we cannot make sure the 'reg_size' will always be none zero here, and then if 'reg_size' equals to zero, the kzalloc() will return ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the 'reg_size' zero check before calling kzalloc().

---
 sound/soc/soc-cache.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/soc-cache.c +3 -0
index 3fa77d5..8fff5b6 100644
@@ -72,6 +72,9 @@ int snd_soc_cache_init(struct snd_soc_codec *codec)
 
 	reg_size = codec_drv->reg_cache_size * codec_drv->reg_word_size;
 
+	if (!reg_size)
+		return -EINVAL;
+
 	mutex_init(&codec->cache_rw_mutex);
 
 	dev_dbg(codec->dev, "ASoC: Initializing cache for %s codec\n",
Signature · 1 line
1.8.4
maintainer Applied
#1 lore raw
Quoted 3 lines · Xiubo Li

Since we cannot make sure the 'reg_size' will always be none zero here, and then if 'reg_size' equals to zero, the kzalloc() will return ZERO_SIZE_PTR, which equals to ((void *)16).

Applied, thanks.