Skip to contentSkip to conversation

ia64: CONFIG_PARAVIRT_GUEST_ASM_CLOBBER_CHECK?

DISCUSSION Paul Bolle 2 participants 4 messages May 22, 2014 – May 28, 2014

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

Isaku,

v2.6.27 shipped with commit e92e8c68a61a ("[IA64] pvops: define paravirtualized instructions for native."). That commit added a preprocessor test for CONFIG_PARAVIRT_GUEST_ASM_CLOBBER_CHECK to arch/ia64/include/asm/native/inst.h.

There never was a Kconfig symbol PARAVIRT_GUEST_ASM_CLOBBER_CHECK, so this test has always evaluated to false.

Was this macro intended to be set through the kconfig tools? Or was it perhaps intended to be set manually whenever one wanted to use it? Either way, is that macro and the code currently hidden behind it still needed?

Regards,

Paul Bolle

author
#1 lore raw

Tony, Fenghua,

Quoted 5 lines · Paul Bolle

v2.6.27 shipped with commit e92e8c68a61a ("[IA64] pvops: define paravirtualized instructions for native."). That commit added a preprocessor test for CONFIG_PARAVIRT_GUEST_ASM_CLOBBER_CHECK to arch/ia64/include/asm/native/inst.h.

Quoted 7 lines

There never was a Kconfig symbol PARAVIRT_GUEST_ASM_CLOBBER_CHECK, so this test has always evaluated to false.

Was this macro intended to be set through the kconfig tools? Or was it perhaps intended to be set manually whenever one wanted to use it? Either way, is that macro and the code currently hidden behind it still needed?

Isaku's address bounces. So I'm not likely to get a reply from Isaku. Could one of you please have a look at this?

Paul Bolle

#2 lore raw
In reply to Paul Bolle

PiBXYXMgdGhpcyBtYWNybyBpbnRlbmRlZCB0byBiZSBzZXQgdGhyb3VnaCB0aGUga2NvbmZpZyB0 b29scz8gT3Igd2FzIGl0DQo+IHBlcmhhcHMgaW50ZW5kZWQgdG8gYmUgc2V0IG1hbnVhbGx5IHdo ZW5ldmVyIG9uZSB3YW50ZWQgdG8gdXNlIGl0Pw0KPiBFaXRoZXIgd2F5LCBpcyB0aGF0IG1hY3Jv IGFuZCB0aGUgY29kZSBjdXJyZW50bHkgaGlkZGVuIGJlaGluZCBpdCBzdGlsbA0KPiBuZWVkZWQ/ DQoNCkkgdGhpbmsgaXQgbWF5IGJlIG1vb3QuICBYZW4gc3VwcG9ydCB3YXMgcmlwcGVkIG91dCBp biBEZWNlbWJlciBsYXN0DQp5ZWFyIGJ5IGNvbW1pdCBkNTJlZWZiNDdkNCAuLi4gc28gdGhpcyBl dmVuIGlmIHRoaXMgUEFSQVZJUlQgcGllY2UNCm9uZSBkaWQgc29tZXRoaW5nLCBpdCBpcyBhbGwg aGlzdG9yeSBub3cuDQoNCi1Ub255IA0K

author
#3 lore raw
In reply to Paul Bolle
Quoted 8 lines · Tony
Quoted 4 lines

Was this macro intended to be set through the kconfig tools? Or was it perhaps intended to be set manually whenever one wanted to use it? Either way, is that macro and the code currently hidden behind it still needed?

I think it may be moot. Xen support was ripped out in December last year by commit d52eefb47d4 ... so this even if this PARAVIRT piece one did something, it is all history now.

Should I draft an (untested, I'm afraid) patch to remove CONFIG_PARAVIRT_GUEST_ASM_CLOBBER_CHECK and everything hidden behind it? Or would you prefer to do that yourself?

Thanks,

Paul Bolle