Skip to contentSkip to conversation

combo-layer: git revlist does't take account about file_filter

PATCH New João Henrique Ferreira de Freitas 2 participants 3 messages May 29, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 combo-layer: git revlist does't take account about file_filter

Hello,

This fixes a combo-layer behaviour that I found using this .conf:

[meta-intel]
src_uri = git://git.yoctoproject.org/meta-intel
local_repo_dir = /home/joaohf/jhf/opensource/meta/meta-intel dest_dir = .
branch = daisy
last_revision =
file_filter = conf common meta-crownbay

The first time that I run, everything was Ok. But the second time was a mess.

combo-layer took the wrongly last_revision and was trying to use it to compute its revlist.

The patch fix the 'git rev-list' command passing file_filter that 'git format-patch' uses.

I don't know if my assumptions are correct but 'git rev-list' really needs to take account about file_filter too.

João Henrique Ferreira de Freitas (1):
combo-layer: fix revlist taking into account file_filter

 scripts/combo-layer | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 combo-layer: fix revlist taking into account file_filter

If file_filter is set, git format-patch takes account but git rev-list does not. So revlist is going to get with wrong revisions. And last_revision will be updated with wrong revision. The next time that user run combo-layer it complain about applying patches.

So ensure that 'git rev-list' are using file_filter as 'git format-patch'.

---
 scripts/combo-layer | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/combo-layer +1 -1
index 9da1d3a..19d64e6 100755
@@ -395,7 +395,7 @@ def action_update(conf, args):
         logger.debug("generated patch set:\n%s" % output)
         patchlist = output.splitlines()
 
-        rev_cmd = 'git rev-list --no-merges ' + rev_cmd_range
+        rev_cmd = "git rev-list --no-merges %s -- %s" % (rev_cmd_range, file_filter)
         revlist = runcmd(rev_cmd, ldir).splitlines()
 
         # Step 3: Call repo specific hook to adjust patch
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH] combo-layer: fix revlist taking into account file_filter

Quoted 17 lines · On Wednesday 28 May 2014 23:53:51 João Henrique Ferreira de Freitas wrote:

If file_filter is set, git format-patch takes account but git rev-list does not. So revlist is going to get with wrong revisions. And last_revision will be updated with wrong revision. The next time that user run combo-layer it complain about applying patches.

So ensure that 'git rev-list' are using file_filter as 'git format-patch'.

---
 scripts/combo-layer | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/combo-layer +0 -0
index 9da1d3a..19d64e6 100755

scripts/combo-layer def action_update(conf, args): · line 401

Quoted 8 lines
scripts/combo-layer +1 -1
@@ -395,7 +395,7 @@ def action_update(conf, args):
         logger.debug("generated patch set:\n%s" % output)
         patchlist = output.splitlines()
 
-        rev_cmd = 'git rev-list --no-merges ' + rev_cmd_range
+        rev_cmd = "git rev-list --no-merges %s -- %s" % (rev_cmd_range,
 file_filter) revlist = runcmd(rev_cmd, ldir).splitlines()
 
         # Step 3: Call repo specific hook to adjust patch

You're right, I'm not sure how we didn't pick up on this earlier. Thanks!

Cheers,
Paul
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.