Skip to contentSkip to conversation

ASoC: intel: The Baytrail/MAX98090 driver depends on I2C

PATCH In review Mark Brown 2 participants 3 messages Jun 1, 2014 – Jun 2, 2014

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 ASoC: intel: The Baytrail/MAX98090 driver depends on I2C

From: Mark Brown <[email protected]>

---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/Kconfig +1 -1
index cd3498736e91..c30fedb3e149 100644
@@ -52,7 +52,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH
 
 config SND_SOC_INTEL_BYT_MAX98090_MACH
 	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
-	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
+	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C
 	select SND_SOC_INTEL_BAYTRAIL
 	select SND_SOC_MAX98090
 	help
Signature · 1 line
2.0.0.rc4
#1 lore raw

Hi Mark,

Quoted 12 lines

From: Mark Brown <[email protected]>

---
 sound/soc/intel/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/Kconfig +0 -0
index cd3498736e91..c30fedb3e149 100644

sound/soc/intel/Kconfig config SND_SOC_INTEL_BYT_RT5640_MACH · line 55

Quoted 5 lines
sound/soc/intel/Kconfig +1 -1
@@ -52,7 +52,7 @@ config SND_SOC_INTEL_BYT_RT5640_MACH
 
 config SND_SOC_INTEL_BYT_MAX98090_MACH
 	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
-	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
+	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C

I think the dependency on I2C is specific to the MAX98090 codec. Can we add this to the codec config entry instead?

Thanks,
Kevin

Quoted 11 lines
sound/soc/intel/Kconfig +0 -1
 	select SND_SOC_INTEL_BAYTRAIL
 	select SND_SOC_MAX98090
 	help
--

2.0.0.rc4

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

author maintainer
#2 lore raw
Quoted 6 lines · On Sun, Jun 01, 2014 at 06:30:03PM -0700, [email protected] wrote:

sound/soc/intel/Kconfig config SND_SOC_INTEL_BYT_RT5640_MACH · line 55

Quoted 3 lines
sound/soc/intel/Kconfig +1 -1
 	tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
-	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS
+	depends on SND_SOC_INTEL_SST && X86_INTEL_LPSS && I2C

I think the dependency on I2C is specific to the MAX98090 codec. Can we add this to the codec config entry instead?

No, selects ignore dependencies.